mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] bootm: update os_entry from uimage
Date: Mon, 23 Sep 2013 16:32:26 +0200	[thread overview]
Message-ID: <20130923143226.GH31585@ns203013.ovh.net> (raw)
In-Reply-To: <20130923091309.GB17135@pengutronix.de>

On 11:13 Mon 23 Sep     , Sascha Hauer wrote:
> On Mon, Sep 23, 2013 at 10:16:00AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 17:20 Sat 21 Sep     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > if not uimage set 0 by default
> > > 
> > > today we do not see the issue as the kernel entry point is the same as the
> > > load_addr but on other binary its not necessary the case
> > > 
> > > as today we ignore the entry point set in the uimage and just assume it's the
> > > same as the load_addr
> > > 
> > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > ---
> > 
> > this patch will also prepare to add a globalval and a getopt to overwrite the
> > os_entry
> 
> We already have a getopt to overwrite the os_entry: -e
> 
> > 
> > yours do not care about this preparation by not setting
> > data.os_entry = UIMAGE_SOME_ADDRESS;
> 
> Because UIMAGE_SOME_ADDRESS is not suitable for a relative offset to the
> image start.

I use this ti let known th e uimage code that the os_entry is not overwrite
and that it must not modify it

because if you specify  via getopt or global and do not set UIMAGE_SOME_ADDRESS
the uimage code will overwrite the provided value

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-09-23 14:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 15:20 Jean-Christophe PLAGNIOL-VILLARD
2013-09-22 18:17 ` Sascha Hauer
2013-09-23  4:40   ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-23  6:33     ` Sascha Hauer
2013-09-23  8:07       ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-23  8:12         ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-23  9:11           ` Sascha Hauer
2013-09-23  8:16 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-23  9:13   ` Sascha Hauer
2013-09-23 14:32     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-09-23 14:54       ` Sascha Hauer
2013-09-24  9:26         ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130923143226.GH31585@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox