Wrong barebox_image_size value

Wrong barebox_image_size value

[Rostislav Lisovy]

Dear barebox developers and users;
I am compiling barebox for freescale-imx53-smd board. My issue is,
that the image does not contain the correct size record.
The "bootloader size" needed by the flashing tool is initialized in
freescale-mx53-smd/flash_header.c, in structure flash_header,
field .boot_data.size.
Formerly there used to be a hardcoded value 0x40000, nowadays we use
DCD_BAREBOX_SIZE which expands into (barebox_image_size + 4095), where
"barebox_image_size" has real size computed by the linker.
When the value .boot_data.size is filled by hand (as 0x40000), correct
value is stored in the barebox image.
Proof: hexdump -s 0x24 -n 4 barebox-flash-image
0000024 0000 0004

however if .boot_data.size = DCD_BAREBOX_SIZE,
$ hexdump -s 0x24 -n 4 barebox-flash-image
0000024 0fff 0000
where this 0xfff is the "+4095" added to round the value. (I am pretty
sure the offset into the image used by hexdump is correct).

The barebox version I am using most recent git, branch master.
The compiler (maybe here is the point of failure) is
arm-cortex_a8-linux-gnueabi-gcc (crosstool-NG hg+default-86a8d1d467c8)
4.4.6.

I will appreciate any help;
Rostislav Lisovy


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Wrong barebox_image_size value

[Jean-Christophe PLAGNIOL-VILLARD]

On 22:30 Thu 26 Sep     , Rostislav Lisovy wrote:
> Dear barebox developers and users;
> I am compiling barebox for freescale-imx53-smd board. My issue is,
> that the image does not contain the correct size record.
> The "bootloader size" needed by the flashing tool is initialized in
> freescale-mx53-smd/flash_header.c, in structure flash_header,
> field .boot_data.size.
> Formerly there used to be a hardcoded value 0x40000, nowadays we use
> DCD_BAREBOX_SIZE which expands into (barebox_image_size + 4095), where
> "barebox_image_size" has real size computed by the linker.
> When the value .boot_data.size is filled by hand (as 0x40000), correct
> value is stored in the barebox image.
> Proof: hexdump -s 0x24 -n 4 barebox-flash-image
> 0000024 0000 0004
> 
> however if .boot_data.size = DCD_BAREBOX_SIZE,
> $ hexdump -s 0x24 -n 4 barebox-flash-image
> 0000024 0fff 0000
> where this 0xfff is the "+4095" added to round the value. (I am pretty
> sure the offset into the image used by hexdump is correct).
> 
> The barebox version I am using most recent git, branch master.
> The compiler (maybe here is the point of failure) is
> arm-cortex_a8-linux-gnueabi-gcc (crosstool-NG hg+default-86a8d1d467c8)
> 4.4.6.

do you compile a relocation binary?

if yes the barebox size is 0 for the linker script

I send a patch for the -next to start to fix the issue but I think we need
other fixup

Best Regards,
J.
> 
> I will appreciate any help;
> Rostislav Lisovy
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Wrong barebox_image_size value

[Sascha Hauer]

Hi Rostislav,

On Thu, Sep 26, 2013 at 10:30:29PM +0200, Rostislav Lisovy wrote:
> Dear barebox developers and users;
> I am compiling barebox for freescale-imx53-smd board. My issue is,
> that the image does not contain the correct size record.
> The "bootloader size" needed by the flashing tool is initialized in
> freescale-mx53-smd/flash_header.c, in structure flash_header,
> field .boot_data.size.
> Formerly there used to be a hardcoded value 0x40000, nowadays we use
> DCD_BAREBOX_SIZE which expands into (barebox_image_size + 4095), where
> "barebox_image_size" has real size computed by the linker.
> When the value .boot_data.size is filled by hand (as 0x40000), correct
> value is stored in the barebox image.
> Proof: hexdump -s 0x24 -n 4 barebox-flash-image
> 0000024 0000 0004
> 
> however if .boot_data.size = DCD_BAREBOX_SIZE,
> $ hexdump -s 0x24 -n 4 barebox-flash-image
> 0000024 0fff 0000
> where this 0xfff is the "+4095" added to round the value. (I am pretty
> sure the offset into the image used by hexdump is correct).

Probably you are not building the defconfig, right? Compiling the
defconfig gives me the correct value and it's at offset 0x424 in the
image, not at 0x24.
Maybe you are compiling a relocatable image as Jean-Christophe
mentioned, then you would see this problem.

> 
> The barebox version I am using most recent git, branch master.
> The compiler (maybe here is the point of failure) is
> arm-cortex_a8-linux-gnueabi-gcc (crosstool-NG hg+default-86a8d1d467c8)
> 4.4.6.

That should be ok.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Wrong barebox_image_size value

[Rostislav Lisovy]

Thank you for your help;
The problem is really the relocatable binary.
I did not use freescale_mx53_smd_defconfig because I wanted to do it
"may way" (which is wrong in this case).
If I unset config options RELOCATABLE and PBL_RELOCATABLE (or unset
PBL_IMAGE), the proper size value is written to the image.

Best regards;
Rostislav Lisovy


On Fri, 2013-09-27 at 08:54 +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote: 
> On 22:30 Thu 26 Sep     , Rostislav Lisovy wrote:
> > Dear barebox developers and users;
> > I am compiling barebox for freescale-imx53-smd board. My issue is,
> > that the image does not contain the correct size record.
> > The "bootloader size" needed by the flashing tool is initialized in
> > freescale-mx53-smd/flash_header.c, in structure flash_header,
> > field .boot_data.size.
> > Formerly there used to be a hardcoded value 0x40000, nowadays we use
> > DCD_BAREBOX_SIZE which expands into (barebox_image_size + 4095), where
> > "barebox_image_size" has real size computed by the linker.
> > When the value .boot_data.size is filled by hand (as 0x40000), correct
> > value is stored in the barebox image.
> > Proof: hexdump -s 0x24 -n 4 barebox-flash-image
> > 0000024 0000 0004
> > 
> > however if .boot_data.size = DCD_BAREBOX_SIZE,
> > $ hexdump -s 0x24 -n 4 barebox-flash-image
> > 0000024 0fff 0000
> > where this 0xfff is the "+4095" added to round the value. (I am pretty
> > sure the offset into the image used by hexdump is correct).
> > 
> > The barebox version I am using most recent git, branch master.
> > The compiler (maybe here is the point of failure) is
> > arm-cortex_a8-linux-gnueabi-gcc (crosstool-NG hg+default-86a8d1d467c8)
> > 4.4.6.
> 
> do you compile a relocation binary?
> 
> if yes the barebox size is 0 for the linker script
> 
> I send a patch for the -next to start to fix the issue but I think we need
> other fixup
> 
> Best Regards,
> J.
> > 
> > I will appreciate any help;
> > Rostislav Lisovy
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: Wrong barebox_image_size value

[Rostislav Lisovy]

Hello Sascha;
You are right; The problem is I did not use the defconfig, thus building
relocatable binary. After using freescale_mx53_smd_defconfig, proper
size value is stored in the image.
Thank you for the help;

Rostislav Lisovy


On Fri, 2013-09-27 at 10:05 +0200, Sascha Hauer wrote: 
> Hi Rostislav,
> 
> On Thu, Sep 26, 2013 at 10:30:29PM +0200, Rostislav Lisovy wrote:
> > Dear barebox developers and users;
> > I am compiling barebox for freescale-imx53-smd board. My issue is,
> > that the image does not contain the correct size record.
> > The "bootloader size" needed by the flashing tool is initialized in
> > freescale-mx53-smd/flash_header.c, in structure flash_header,
> > field .boot_data.size.
> > Formerly there used to be a hardcoded value 0x40000, nowadays we use
> > DCD_BAREBOX_SIZE which expands into (barebox_image_size + 4095), where
> > "barebox_image_size" has real size computed by the linker.
> > When the value .boot_data.size is filled by hand (as 0x40000), correct
> > value is stored in the barebox image.
> > Proof: hexdump -s 0x24 -n 4 barebox-flash-image
> > 0000024 0000 0004
> > 
> > however if .boot_data.size = DCD_BAREBOX_SIZE,
> > $ hexdump -s 0x24 -n 4 barebox-flash-image
> > 0000024 0fff 0000
> > where this 0xfff is the "+4095" added to round the value. (I am pretty
> > sure the offset into the image used by hexdump is correct).
> 
> Probably you are not building the defconfig, right? Compiling the
> defconfig gives me the correct value and it's at offset 0x424 in the
> image, not at 0x24.
> Maybe you are compiling a relocatable image as Jean-Christophe
> mentioned, then you would see this problem.
> 
> > 
> > The barebox version I am using most recent git, branch master.
> > The compiler (maybe here is the point of failure) is
> > arm-cortex_a8-linux-gnueabi-gcc (crosstool-NG hg+default-86a8d1d467c8)
> > 4.4.6.
> 
> That should be ok.
> 
> Sascha
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox