Re: [PATCH 4/8] console: introduce startup and shutdown

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 11:09 Fri 27 Sep     , Sascha Hauer wrote:
> On Fri, Sep 27, 2013 at 11:03:57AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:55 Fri 27 Sep     , Sascha Hauer wrote:
> > > On Fri, Sep 27, 2013 at 09:14:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > so enable the uart only if used
> > > > so linux can detect the right one enable if it want
> > > > +{
> > > > +	int ret;
> > > > +
> > > > +	if (cdev->f_active)
> > > > +		return 0;
> > > > +
> > > > +	if (cdev->startup) {
> > > > +		ret = cdev->startup(cdev);
> > > > +		if (ret)
> > > > +			return ret;
> > > > +	}
> > > > +
> > > > +	if (cdev->setbrg) {
> > > > +		cdev->baudrate = CONFIG_BAUDRATE;
> > > 
> > > I believe cdev->baudrate should be set only once during initialization.
> > > When I deactivate a console and activate it again I don't expect the
> > > baudrate to be changed to it's default value.
> > 
> > maybe but if the device is not a console but rs485 you never set the baudrate
> > today same if a device is never active
> > 
> > as example use a non active device for loadxy
> > 
> > so I'm think that the console_open is more like man 2 open + ioctl to use a
> > cdev
> 
> Put a cdev->baudrate = CONFIG_BAUDRATE in console_register() instead of
> console_open. This doesn't affect RS485 at all but fixes the behaviour i
> moaned about.

ok why not

Best Regards,
J.
> 
> Sascha
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox