mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: omap: Fix default value of mci.f_max
Date: Fri, 27 Sep 2013 15:40:38 +0200	[thread overview]
Message-ID: <20130927134038.GA25753@omega> (raw)
In-Reply-To: <20130927133807.GI32444@ns203013.ovh.net>

Hi,

On Fri, Sep 27, 2013 at 03:38:07PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:13 Fri 27 Sep     , Teresa G??mez wrote:
> > Set default value of mci.f_max even when no pdata
> > is available.
> > 
> > Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> > ---
> >  drivers/mci/omap_hsmmc.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> > index a2cd3fe..f63697f 100644
> > --- a/drivers/mci/omap_hsmmc.c
> > +++ b/drivers/mci/omap_hsmmc.c
> > @@ -614,11 +614,11 @@ static int omap_mmc_probe(struct device_d *dev)
> >  	if (pdata) {
> >  		if (pdata->f_max)
> >  			hsmmc->mci.f_max = pdata->f_max;
> > -		else
> > -			hsmmc->mci.f_max = 52000000;
> >  
> >  		if (pdata->devname)
> >  			hsmmc->mci.devname = pdata->devname;
> > +	} else {
> > +		hsmmc->mci.f_max = 52000000;
> >  	}
> 
> so do this
> 
> 	if (!hsmmc->mci.f_maix)
> 		hsmmc->mci.f_max = 52000000;

perfect :-)

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-09-27 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27 12:13 Teresa Gámez
2013-09-27 12:19 ` Alexander Aring
2013-09-27 13:29   ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27 13:36     ` Alexander Aring
2013-09-27 13:38 ` Jean-Christophe PLAGNIOL-VILLARD
2013-09-27 13:40   ` Alexander Aring [this message]
2013-09-27 13:45     ` Alexander Aring
2013-09-27 13:52       ` Teresa Gamez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927134038.GA25753@omega \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox