mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCHv2] mci: omap: Fix default value of mci.f_max
Date: Wed, 2 Oct 2013 10:26:57 +0200	[thread overview]
Message-ID: <20131002082657.GG30088@pengutronix.de> (raw)
In-Reply-To: <1380694950-20022-1-git-send-email-t.gamez@phytec.de>

On Wed, Oct 02, 2013 at 08:22:30AM +0200, Teresa Gámez wrote:
> With commit c2ef47887 mci.f_max default value is
> only set when pdata is available.
> 
> Fix this with always setting the mci.f_max default
> value and overrite it when pdata available.
> 
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>

Applied, thanks

Sascha

> ---
> changes in v2:
> - set default value always and overwrite it when pdata available 
> - updated commit message
> 
>  drivers/mci/omap_hsmmc.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mci/omap_hsmmc.c b/drivers/mci/omap_hsmmc.c
> index a2cd3fe..19db461 100644
> --- a/drivers/mci/omap_hsmmc.c
> +++ b/drivers/mci/omap_hsmmc.c
> @@ -609,19 +609,17 @@ static int omap_mmc_probe(struct device_d *dev)
>  	hsmmc->mci.voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
>  
>  	hsmmc->mci.f_min = 400000;
> +	hsmmc->mci.f_max = 52000000;
>  
>  	pdata = (struct omap_hsmmc_platform_data *)dev->platform_data;
>  	if (pdata) {
>  		if (pdata->f_max)
>  			hsmmc->mci.f_max = pdata->f_max;
> -		else
> -			hsmmc->mci.f_max = 52000000;
>  
>  		if (pdata->devname)
>  			hsmmc->mci.devname = pdata->devname;
>  	}
>  
> -
>  	dev->priv = hsmmc;
>  	dev->detect = omap_mmc_detect,
>  
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-10-02  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02  6:22 Teresa Gámez
2013-10-02  8:26 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002082657.GG30088@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=t.gamez@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox