mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/6] ARM: vexpress: Fix compiler warning
Date: Wed, 2 Oct 2013 10:27:57 +0200	[thread overview]
Message-ID: <20131002082757.GH30088@pengutronix.de> (raw)
In-Reply-To: <20131001132250.GK32444@ns203013.ovh.net>

On Tue, Oct 01, 2013 at 03:22:50PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:22 Tue 01 Oct     , Sascha Hauer wrote:
> > Fixes:
> > 
> > arch/arm/boards/vexpress/init.c: In function 'vexpress_core_init':
> > arch/arm/boards/vexpress/init.c:139:22: warning: 'hostname' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  arch/arm/boards/vexpress/init.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boards/vexpress/init.c b/arch/arm/boards/vexpress/init.c
> > index 48bc11e..5358be3 100644
> > --- a/arch/arm/boards/vexpress/init.c
> > +++ b/arch/arm/boards/vexpress/init.c
> > @@ -133,6 +133,8 @@ static int vexpress_core_init(void)
> >  			hostname = "vexpress-a9";
> >  		else if (cpu_is_cortex_a15())
> >  			hostname = "vexpress-a15";
> > +		else
> > +			hostname = "vexpress-unknown";
> 
> so set hostname by default not on else

Ok, changed this.

Sascha

> >  	}
> >  
> >  	barebox_set_model("ARM Vexpress");
> > -- 
> > 1.8.4.rc3
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-10-02  8:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  6:22 Compiler warning fixes Sascha Hauer
2013-10-01  6:22 ` [PATCH 1/6] ARM: edb93xx: Add missing include Sascha Hauer
2013-10-01  6:22 ` [PATCH 2/6] ARM: friendlyarm-tiny210: remove unused variable Sascha Hauer
2013-10-01  6:22 ` [PATCH 3/6] ARM: mx23-evk: Fix result checking of devfs_add_partition Sascha Hauer
2013-10-01  7:49   ` Uwe Kleine-König
2013-10-02  8:29     ` Sascha Hauer
2013-10-01  6:22 ` [PATCH 4/6] ARM: Ka-Ro TX28: " Sascha Hauer
2013-10-01  6:22 ` [PATCH 5/6] ARM: vexpress: Fix compiler warning Sascha Hauer
2013-10-01 13:22   ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-02  8:27     ` Sascha Hauer [this message]
2013-10-01  6:22 ` [PATCH 6/6] mips: bcm47xx: " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002082757.GH30088@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox