Re: [PATCH] gpio: Add designware gpio controller support

From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] gpio: Add designware gpio controller support
Date: Thu, 17 Oct 2013 10:38:29 +0200	[thread overview]
Message-ID: <20131017083829.GN14042@pengutronix.de> (raw)
In-Reply-To: <525F9EAB.50104@gmail.com>

On Thu, Oct 17, 2013 at 10:24:11AM +0200, Sebastian Hesselbarth wrote:
> On 10/17/2013 10:04 AM, Steffen Trumtrar wrote:
> >On Mon, Sep 09, 2013 at 06:28:48PM +0200, Sebastian Hesselbarth wrote:
> >>On 09/09/13 16:54, Sascha Hauer wrote:
> >>>Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >>>---
> >>>  drivers/gpio/Kconfig   |   6 ++
> >>>  drivers/gpio/Makefile  |   1 +
> >>>  drivers/gpio/gpio-dw.c | 151 +++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  3 files changed, 158 insertions(+)
> >>>  create mode 100644 drivers/gpio/gpio-dw.c
> >>>
> >>>diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> >>>index d5ac532..18d3135 100644
> >>>--- a/drivers/gpio/Kconfig
> >>>+++ b/drivers/gpio/Kconfig
> >>>@@ -54,6 +54,12 @@ config GPIO_TEGRA
> >>>  	help
> >>>  	  Say yes here to include the driver for the GPIO controller found on the
> >>>  	  Tegra line of SoCs.
> >>>+
> >>>+config GPIO_DESIGNWARE
> >>>+	tristate "Synopsys DesignWare GPIO driver"
> >>
> >>Sascha,
> >>
> >>I know DW's GPIO is also used on Armada 1500 which I currently work on.
> >>Precisely, the IP is named dw-apb-gpio. Maybe the above should also
> >>reflect APB.
> >>
> >>[...]
> >>
> >>Please add "snps,dw-apb-gpio", that's what the linux driver
> >>will look for if make to pick it up for Armada 1500.
> >>
> >
> >Are you talking about the 'old' linux driver that was posted sometime around
> >January 2012 or are you working on your own?
> 
> Cannot recall the actual version or time posted. I didn't find time to
> work on a linux driver for dw-apb-gpio, yet. My idea was to pick up the
> latest driver posted plus make it more general. IIRC the one posted was
> very limited to socfpga.
> 

The one I found, is already used in a picoxcell dts. Altough, no driver is present.
Altera has a driver in their kernel, but the binding is different.
Actually, that is where Sascha got it from. So, let's try and use at least the
binding from Altera ;-)

> >Do you have a working pre-release version somewhere?
> 
> Sorry, nothing started, yet.
> 

Okay.

> Are you going to work on it? If so, feel free to involve me in patches
> and reviews.

If time permits, yes.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox