From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] USB: storage: register disks as usbdiskx
Date: Fri, 18 Oct 2013 15:00:09 +0200 [thread overview]
Message-ID: <20131018130009.GY32444@ns203013.ovh.net> (raw)
In-Reply-To: <1382090851-7993-1-git-send-email-s.hauer@pengutronix.de>
On 12:07 Fri 18 Oct , Sascha Hauer wrote:
> To better identify them as USB storage devices. Also make the
> info message look nicer.
we brake the env support
I think it's time to add symblink support to devfs
so we can have disk%x and a usbdisk%x
so we do not brake it
Best Regards,
J.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/usb/storage/usb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index e4b08b9..fbf458f 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -392,12 +392,11 @@ static int usb_stor_add_blkdev(struct us_data *us, struct device_d *dev,
> if (result < 0)
> goto BadDevice;
>
> - result = cdev_find_free_index("disk");
> + result = cdev_find_free_index("usbdisk");
> if (result == -1)
> pr_err("Cannot find a free number for the disk node\n");
> - pr_info("Using index %d for the new disk\n", result);
>
> - pblk_dev->blk.cdev.name = asprintf("disk%d", result);
> + pblk_dev->blk.cdev.name = asprintf("usbdisk%d", result);
> pblk_dev->blk.blockbits = SECTOR_SHIFT;
>
> result = blockdevice_register(&pblk_dev->blk);
> @@ -406,6 +405,8 @@ static int usb_stor_add_blkdev(struct us_data *us, struct device_d *dev,
> goto BadDevice;
> }
>
> + dev_info(dev, "registered /dev/%s\n", pblk_dev->blk.cdev.name);
> +
> /* create partitions on demand */
> result = parse_partition_table(&pblk_dev->blk);
> if (result != 0)
> --
> 1.8.4.rc3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-10-18 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 10:07 Sascha Hauer
2013-10-18 13:00 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018130009.GY32444@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox