From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: phy: Add micrel KSZ8031
Date: Tue, 22 Oct 2013 16:26:33 +0200 [thread overview]
Message-ID: <20131022142633.GA26639@ns203013.ovh.net> (raw)
In-Reply-To: <1382438777-15920-1-git-send-email-mpa@pengutronix.de>
On 12:46 Tue 22 Oct , Markus Pargmann wrote:
> KSZ8031 is similar to KSZ8021. It can use the same functions.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> drivers/net/phy/micrel.c | 9 +++++++++
> include/linux/micrel_phy.h | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c0bcdd1..3cba2c4 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -122,6 +122,15 @@ static struct phy_driver ksphy_driver[] = {
> .config_aneg = genphy_config_aneg,
> .read_status = genphy_read_status,
> }, {
> + .phy_id = PHY_ID_KSZ8031,
> + .phy_id_mask = 0x00ffffff,
> + .drv.name = "Micrel KSZ8031",
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
> + SUPPORTED_Asym_Pause),
> + .config_init = ksz8021_config_init,
> + .config_aneg = genphy_config_aneg,
> + .read_status = genphy_read_status,
> +}, {
> .phy_id = PHY_ID_KSZ8041,
> .phy_id_mask = 0x00fffff0,
> .drv.name = "Micrel KSZ8041",
> diff --git a/include/linux/micrel_phy.h b/include/linux/micrel_phy.h
> index 9dbb41a..8752dbb 100644
> --- a/include/linux/micrel_phy.h
> +++ b/include/linux/micrel_phy.h
> @@ -19,6 +19,7 @@
> #define PHY_ID_KSZ9021 0x00221610
> #define PHY_ID_KS8737 0x00221720
> #define PHY_ID_KSZ8021 0x00221555
> +#define PHY_ID_KSZ8031 0x00221556
you really need this?
because if you use a phy_id_mask of 0x00fffff0 you can use the entry as
PHY_ID_KSZ8021
Best Regards,
J.
> #define PHY_ID_KSZ8041 0x00221510
> #define PHY_ID_KSZ8051 0x00221550
> /* same id: ks8001 Rev. A/B, and ks8721 Rev 3. */
> --
> 1.8.4.rc3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-22 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 10:46 Markus Pargmann
2013-10-22 14:26 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-10-22 14:39 ` Markus Pargmann
2013-10-26 8:12 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022142633.GA26639@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=mpa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox