From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andre Heider <a.heider@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 00/10] RPi mailbox support
Date: Tue, 22 Oct 2013 23:37:35 +0200 [thread overview]
Message-ID: <20131022213735.GO30088@pengutronix.de> (raw)
In-Reply-To: <20131022165729.GA7150@gmail.com>
On Tue, Oct 22, 2013 at 06:57:29PM +0200, Andre Heider wrote:
> On Tue, Oct 22, 2013 at 03:34:05PM +0200, Sascha Hauer wrote:
> > On Sat, Oct 19, 2013 at 02:18:41PM +0200, Andre Heider wrote:
> > > This adds a bcm2835 mailbox driver for the RPi to talk to the on-SoC
> > > VideoCore. See [1] for a description.
> > >
> > > This patchset uses it to get two properties, the eMMC clock and the
> > > memory size.
> > >
> > > The RPi backend needs to use this driver early on, namely before the
> > > MMU setup. We also want to use the driver in the future after the MMU setup,
> > > like setting up simplefb for the kernel. Patch 1 and 2 lay the groundwork
> > > for that.
> > >
> > > The mailbox driver also needs to handle timouts, so patch 5 and 6 are
> > > making the clocksource accessible earlier.
> > >
> > > Patch 7 is the driver itself, providing a helper macro for users based on
> > > a new common macro from patch 3.
> > >
> > > Patch 8 and 9 switch the bc2835_mci driver from a local mailbox
> > > implementation to the new driver.
> > >
> > > Patch 10 uses the driver to get the proper memory size.
> > >
> > > Patch 4 is just a cleanup.
> >
> > Applied, thanks. I'll probably have a closer look at the caching bits
> > later, but looks good for now.
>
> Thanks Sascha!
> Any particular concerns about the caching bits?
I'm concerned about "only invalidate caches if we have functions to do
so". This could lead to some quiet bugs when we really ought to
invalidate caches but missed to setup the functions early enough.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-10-22 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 12:18 Andre Heider
2013-10-19 12:18 ` [PATCH 01/10] ARM: cache: restore cache functions from the PBL Andre Heider
2013-10-19 12:20 ` [PATCH 02/10] ARM: cache: do not crash when the MMU isn't yet setup Andre Heider
2013-10-19 12:20 ` [PATCH 03/10] common: add a macro to align an array on the stack Andre Heider
2013-10-19 12:20 ` [PATCH 04/10] ARM: bcm2835: cleanup clock registering Andre Heider
2013-10-19 12:20 ` [PATCH 05/10] ARM: bcm2835: register the clocksource driver earlier Andre Heider
2013-10-19 12:20 ` [PATCH 06/10] ARM: bcm2835: register the clocksource device earlier Andre Heider
2013-10-19 12:20 ` [PATCH 07/10] ARM: bcm2835: add a mailbox driver for VideoCore Andre Heider
2013-10-19 12:20 ` [PATCH 08/10] ARM: rpi: register a clkdev for the eMMC clock Andre Heider
2013-10-19 12:20 ` [PATCH 09/10] mci: bcm2835: use the registered device clkdev Andre Heider
2013-10-19 12:21 ` [PATCH 10/10] ARM: rpi: use the proper ARM memory size Andre Heider
2013-10-21 8:46 ` [PATCH 00/10] RPi mailbox support Sascha Hauer
2013-10-21 15:32 ` Andre Heider
2013-10-22 13:34 ` Sascha Hauer
2013-10-22 16:57 ` Andre Heider
2013-10-22 21:37 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022213735.GO30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.heider@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox