From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] ppc: DA923RC: add board support
Date: Fri, 1 Nov 2013 12:58:52 +0100 [thread overview]
Message-ID: <20131101115852.GL24559@pengutronix.de> (raw)
In-Reply-To: <5272B934.7080508@ge.com>
On Thu, Oct 31, 2013 at 08:10:28PM +0000, Renaud Barbier wrote:
> On 31/10/2013 07:48, Sascha Hauer wrote:
> >>> +
> >>> > > + fsl_i2c_init(0, 400000, 0x7f);
> >>> > > + /* Read board id from offset 0. */
> >>> > > + ret = fsl_i2c_read(i2c, 0x3b, 0, 1, &id, sizeof(uint8_t));
> >>> > > + fsl_i2c_stop(i2c);
> >>> > > +
> >>> > > + if (ret == -1) {
> >>> > > + /* Enable I2C bus on GBX460. */
> >>> > > + out_be16(IOMEM(0xfc010020), 0);
> >>> > > + ret = fsl_i2c_read(i2c, 0x3b, 0, 1, &id, sizeof(uint8_t));
> >>> > > + fsl_i2c_stop(i2c);
> >> > why you do not simly use the standdard i2c AP?
> > I think because the machine is still running from SRAM or flash here and
> > I2C is needed to read out the SPD EEPROM for setting up SDRAM.
> >
>
> In order to use the I2C API would I not need to register my i2c bus
> first? This only happens later in the initcall list with device-initcall.
Yes, You would have to have your i2c bus registered. Can't you move the
above to late_initcall?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-01 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 10:22 [PATCH v2 0/5] GEIP DA923RC " Renaud Barbier
2013-10-30 10:22 ` [PATCH 1/5] ppc: mpc85xx: mpc8544 support Renaud Barbier
2013-10-30 10:22 ` [PATCH 2/5] ppc: mpc85xx: define Ethernet port count Renaud Barbier
2013-10-30 10:22 ` [PATCH 3/5] ppc: mpc85xx: enable DDR driver Renaud Barbier
2013-10-30 10:22 ` [PATCH 4/5] ppc: DA923RC: add board support Renaud Barbier
2013-10-30 11:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 7:48 ` Sascha Hauer
2013-10-31 13:15 ` Renaud Barbier
2013-10-31 20:10 ` Renaud Barbier
2013-11-01 11:58 ` Sascha Hauer [this message]
2013-11-01 12:56 ` Renaud Barbier
2013-11-01 13:02 ` Renaud Barbier
2013-11-01 15:03 ` Renaud Barbier
2013-11-01 20:28 ` Sascha Hauer
2013-11-04 18:06 ` Renaud Barbier
2013-11-05 7:35 ` Sascha Hauer
2013-10-31 14:41 ` Renaud Barbier
2013-10-31 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 18:59 ` Renaud Barbier
2013-10-30 10:22 ` [PATCH 5/5] ppc: mpc85xx: build directives Renaud Barbier
2013-11-05 15:36 [PATCH v3 0/5] GEIP DA923RC board support Renaud Barbier
2013-11-05 15:36 ` [PATCH 4/5] ppc: DA923RC: add " Renaud Barbier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101115852.GL24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox