From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 0/6] BCM2835 / simple framebuffer support
Date: Wed, 6 Nov 2013 11:18:19 +0100 [thread overview]
Message-ID: <20131106101819.GB15858@x61s.campuswlan.hs-rm.de> (raw)
In-Reply-To: <20131106100232.GL24559@pengutronix.de>
On Wed, Nov 06, 2013 at 11:02:33AM +0100, Sascha Hauer wrote:
> On Wed, Nov 06, 2013 at 11:04:02AM +0100, Alexander Aring wrote:
> > Hi Sascha,
> >
> > On Wed, Nov 06, 2013 at 10:46:28AM +0100, Sascha Hauer wrote:
> > > Hi Andre,
> > > @@ -163,6 +163,13 @@ int register_framebuffer(struct fb_info *info)
> > > if (ret)
> > > goto err_unregister;
> > >
> > > + if (IS_ENABLED(CONFIG_DRIVER_VIDEO_SIMPLEFB)) {
> > > + ret = fb_register_simplefb(info);
> > > + if (ret)
> > > + dev_err(&info->dev, "failed to register simplefb: %s\n",
> > > + strerror(-ret));
> > maybe we should return ret here?
>
> I think it's fine to continue without simplefb here. In the end the
> framebuffer works, just without simplefb.
>
ok, thanks.
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-06 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 23:00 Andre Heider
2013-11-04 23:00 ` [PATCH v2 1/6] fb: add a line_length value to struct fb_info Andre Heider
2013-11-05 0:06 ` Alexander Aring
2013-11-05 8:00 ` Sascha Hauer
2013-11-05 8:17 ` Alexander Aring
2013-11-05 8:48 ` Andre Heider
2013-11-05 8:58 ` Alexander Aring
2013-11-04 23:01 ` [PATCH v2 2/6] gui: convert graphic utils to respect line_length Andre Heider
2013-11-04 23:01 ` [PATCH v2 3/6] gui: convert the bmp renderer " Andre Heider
2013-11-04 23:01 ` [PATCH v2 4/6] ARM: bcm2835: add missing mbox overscan response field Andre Heider
2013-11-04 23:01 ` [PATCH v2 5/6] video: add a BCM2835 framebuffer driver Andre Heider
2013-11-04 23:01 ` [PATCH v2 6/6] video: set up the kernel's simple " Andre Heider
2013-11-06 9:46 ` [PATCH v2 0/6] BCM2835 / simple framebuffer support Sascha Hauer
2013-11-06 10:04 ` Alexander Aring
2013-11-06 10:02 ` Sascha Hauer
2013-11-06 10:18 ` Alexander Aring [this message]
2013-11-06 17:40 ` Andre Heider
2013-11-12 12:14 ` Andre Heider
2013-11-12 14:19 ` Sascha Hauer
2013-11-14 11:44 ` Andre Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106101819.GB15858@x61s.campuswlan.hs-rm.de \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox