From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Cc: jbe@pengutronix.de
Subject: Re: [PATCH] partitions: dos: parse extended partition
Date: Fri, 8 Nov 2013 01:51:53 +0100 [thread overview]
Message-ID: <20131108005153.GA14892@pengutronix.de> (raw)
In-Reply-To: <1383869846-26033-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hello,
On Fri, Nov 08, 2013 at 01:17:26AM +0100, Uwe Kleine-König wrote:
> DOS MBRs might contain an extended partition that holds several logical
> partitions. Add these to the partitions of the block device.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> common/partitions/dos.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 75 insertions(+), 1 deletion(-)
This even fails to build. See below.
> diff --git a/common/partitions/dos.c b/common/partitions/dos.c
> index 1d8213b..f907abc 100644
> --- a/common/partitions/dos.c
> +++ b/common/partitions/dos.c
> [...]
> @@ -129,6 +181,7 @@ static void dos_partition(void *buf, struct block_device *blk,
> [...]
> + dev_warn(blk->dev, "Skipping additional extended partition\n");
> + }
> +
> } else {
> dev_dbg(blk->dev, "Skipping empty partition %d\n", i);
> }
> }
>
> + if (first_extended_partition)
s/first_//
> + dos_extended_partition(blk, pd, extended_partition);
> +
> dsp = xzalloc(sizeof(*dsp));
> dsp->blk = blk;
>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-08 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 0:17 Uwe Kleine-König
2013-11-08 0:51 ` Uwe Kleine-König [this message]
2013-11-08 10:13 ` [PATCH v2] " Uwe Kleine-König
2013-11-08 14:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108005153.GA14892@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox