From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VfgEC-0002T5-Ra for barebox@lists.infradead.org; Mon, 11 Nov 2013 01:23:45 +0000 Received: by mail-ee0-f42.google.com with SMTP id e52so798661eek.1 for ; Sun, 10 Nov 2013 17:23:21 -0800 (PST) Date: Mon, 11 Nov 2013 02:30:20 +0100 From: Alexander Aring Message-ID: <20131111013019.GA16967@x61s.Speedport_W_921V_1_24_000> References: <1384003450-21001-1-git-send-email-sebastian.hesselbarth@gmail.com> <1384003450-21001-4-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1384003450-21001-4-git-send-email-sebastian.hesselbarth@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/4] gpiolib: make gpiolib command more verbose To: Sebastian Hesselbarth Cc: barebox@lists.infradead.org Hi Sebastian, On Sat, Nov 09, 2013 at 02:24:08PM +0100, Sebastian Hesselbarth wrote: > This adds some more printf information to gpiolib command, like the > gpiochip handling a specific gpio. Also, current direction and value > of the gpio are printed, if the gpiochip provides the corresponding > callbacks. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: barebox@lists.infradead.org > --- > drivers/gpio/gpiolib.c | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index ca6e8ad..c12ebe6 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -228,16 +228,34 @@ static int do_gpiolib(int argc, char *argv[]) > int i; > > printf("gpiolib: gpio lists\n"); > - printf("%*crequested label\n", 11, ' '); > > for (i = 0; i < ARCH_NR_GPIOS; i++) { > struct gpio_info *gi = &gpio_desc[i]; > + int val = -1, dir = -1; > > if (!gi->chip) > continue; > > - printf("gpio %*d: %*s %s\n", 4, > - i, 9, gi->requested ? "true" : "false", > + /* print chip information and header on first gpio */ > + if (gi->chip->base == i) { > + printf("\ngpios %u-%u, chip %s:\n", > + gi->chip->base, > + gi->chip->base + gi->chip->ngpio, I think this should be "gi->chip->base + gi->chip->ngpio - 1", because we starting at zero on base. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox