From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] ARM: at91: Fix signed/unsigned arguments for printf
Date: Mon, 11 Nov 2013 08:52:36 +0100 [thread overview]
Message-ID: <20131111075236.GA24559@pengutronix.de> (raw)
In-Reply-To: <1383934379-27100-1-git-send-email-shc_work@mail.ru>
On Fri, Nov 08, 2013 at 10:12:52PM +0400, Alexander Shiyan wrote:
> "%d" in format string requires a signed integer.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Applied, thanks.
I like Cleanups ;)
Sascha
> ---
> arch/arm/mach-at91/gpio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/gpio.c b/arch/arm/mach-at91/gpio.c
> index b111373..91de85d 100644
> --- a/arch/arm/mach-at91/gpio.c
> +++ b/arch/arm/mach-at91/gpio.c
> @@ -438,7 +438,7 @@ static void at91mux_dump_pio_config(unsigned bank, unsigned pin)
> void __iomem *pio = at91_gpio->regbase;
> u32 div;
>
> - printf("pio%c%d configuration\n\n", bank + 'A', pin);
> + printf("pio%c%u configuration\n\n", bank + 'A', pin);
>
> at91mux_printf_mode(bank, pin);
> printf("\n");
> @@ -499,7 +499,7 @@ static int do_at91mux(int argc, char *argv[])
> }
>
> if (pin >= 32) {
> - printf("pin %d >= supported %d pins\n", pin, 32);
> + printf("pin %u >= supported %d pins\n", pin, 32);
> return 1;
> }
>
> --
> 1.8.1.5
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-11 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 18:12 Alexander Shiyan
2013-11-08 18:12 ` [PATCH] Cleanup Kconfig files Alexander Shiyan
2013-11-08 18:12 ` [PATCH] net/Kconfig: Remove non-existent ARCH_DAVINCI Alexander Shiyan
2013-11-08 18:12 ` [PATCH 2/6] ARM: mxs: Fix signed/unsigned arguments for printf Alexander Shiyan
2013-11-08 18:12 ` [PATCH 3/6] commands: nandtest: " Alexander Shiyan
2013-11-08 18:12 ` [PATCH 4/6] net: netx: " Alexander Shiyan
2013-11-08 18:12 ` [PATCH 5/6] gui: " Alexander Shiyan
2013-11-08 18:12 ` [PATCH 6/6] imx-usb-loader: " Alexander Shiyan
2013-11-11 7:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111075236.GA24559@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox