mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] x86 minor fixes and questions
Date: Mon, 11 Nov 2013 08:57:38 +0100	[thread overview]
Message-ID: <20131111075738.GB24559@pengutronix.de> (raw)
In-Reply-To: <1383935439-23623-1-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

On Fri, Nov 08, 2013 at 07:30:37PM +0100, Thomas Petazzoni wrote:
> Hello,
> 
> Here are two minor fixes for the x86 support. The first patch avoids
> linking problems on recent gcc versions, and the second one fixes the
> documentation.
> 
> Also, I've tested the x86 support under Qemu, it starts fine. Thanks
> to the bios disk driver, it detects one hard disk drive. However,
> since the driver doesn't set num_blocks, the disk size is zero, and no
> partition can be detected. Is this bios disk driver supposed to work
> to read the entire hard drive, access a filesystem and load the kernel
> image, or is the x86 support generally too limited for this at the
> moment?

Does your disk contain a valid partition table? There's no way to
properly detect the disk size, so barebox guesses the size based on the
last partition on the disk. This fails of course on an unpartitioned
device. See disk_guess_size().

But indeed, the x86 support is quite limited.

> Thomas Petazzoni (2):
>   scripts/setupmbr: fix documentation
>   arch/x86: fix link with recent gcc

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-11-11  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 18:30 Thomas Petazzoni
2013-11-08 18:30 ` [PATCH 1/2] scripts/setupmbr: fix documentation Thomas Petazzoni
2013-11-08 18:30 ` [PATCH 2/2] arch/x86: fix link with recent gcc Thomas Petazzoni
2013-11-11  7:57 ` Sascha Hauer [this message]
2013-11-11  9:50   ` [PATCH 0/2] x86 minor fixes and questions Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111075738.GB24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox