From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/2] x86 minor fixes and questions
Date: Mon, 11 Nov 2013 10:50:42 +0100 [thread overview]
Message-ID: <20131111105042.58fa88fa@skate> (raw)
In-Reply-To: <20131111075738.GB24559@pengutronix.de>
Dear Sascha Hauer,
On Mon, 11 Nov 2013 08:57:38 +0100, Sascha Hauer wrote:
> > Also, I've tested the x86 support under Qemu, it starts fine. Thanks
> > to the bios disk driver, it detects one hard disk drive. However,
> > since the driver doesn't set num_blocks, the disk size is zero, and no
> > partition can be detected. Is this bios disk driver supposed to work
> > to read the entire hard drive, access a filesystem and load the kernel
> > image, or is the x86 support generally too limited for this at the
> > moment?
>
> Does your disk contain a valid partition table? There's no way to
> properly detect the disk size, so barebox guesses the size based on the
> last partition on the disk. This fails of course on an unpartitioned
> device. See disk_guess_size().
Yes, my disk had a partition table. However, I see that
disk_guess_size() is only called if you have a DOS partition table, and
not a GPT type of partition table, and I don't remember which type I've
used during my testing.
I'll test again, and with the info that disk_guess_size() is the
important part, I'll have a closer look.
> But indeed, the x86 support is quite limited.
Yeah, no problem. I'm not really planning on making any real use of it,
was just curious to see whether it worked, and if yes, how :-)
> > Thomas Petazzoni (2):
> > scripts/setupmbr: fix documentation
> > arch/x86: fix link with recent gcc
>
> Applied, thanks
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-11 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 18:30 Thomas Petazzoni
2013-11-08 18:30 ` [PATCH 1/2] scripts/setupmbr: fix documentation Thomas Petazzoni
2013-11-08 18:30 ` [PATCH 2/2] arch/x86: fix link with recent gcc Thomas Petazzoni
2013-11-11 7:57 ` [PATCH 0/2] x86 minor fixes and questions Sascha Hauer
2013-11-11 9:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111105042.58fa88fa@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox