mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Vicente Bergas <vicencb@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] OMAP4: fix omap4_bootsource regression
Date: Sun, 24 Nov 2013 18:51:05 +0100	[thread overview]
Message-ID: <20131124175105.GB29652@ns203013.ovh.net> (raw)
In-Reply-To: <1385236704-2309-2-git-send-email-vicencb@gmail.com>

On 20:58 Sat 23 Nov     , Vicente Bergas wrote:
> ---
>  arch/arm/mach-omap/omap4_generic.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
> index 64b0024..6da5cae 100644
> --- a/arch/arm/mach-omap/omap4_generic.c
> +++ b/arch/arm/mach-omap/omap4_generic.c
> @@ -499,20 +499,18 @@ static int omap_vector_init(void)
>  	return 0;
>  }
>  
> -#define OMAP4_TRACING_VECTOR3 0x4030d048
> -
>  static int omap4_bootsource(void)
>  {
> -	enum bootsource src = BOOTSOURCE_UNKNOWN;
> +	enum bootsource src;
init at unknown is good

Best Regards,
J.
>  
>  	switch (omap_bootinfo[2] & 0xFF) {
> -	case 0x03:
> +	case OMAP44XX_SAR_BOOT_NAND:
>  		src = BOOTSOURCE_NAND;
>  		break;
> -	case 0x05:
> +	case OMAP44XX_SAR_BOOT_MMC1:
>  		src = BOOTSOURCE_MMC;
>  		break;
> -	case 0x20:
> +	case OMAP44XX_SAR_BOOT_USB_1:
>  		src = BOOTSOURCE_USB;
>  		break;
>  	default:
> -- 
> 1.8.4.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-11-24 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-23 19:58 [PATCH 1/2] OMAP4: fix writel data/address swap regression Vicente Bergas
2013-11-23 19:58 ` [PATCH 2/2] OMAP4: fix omap4_bootsource regression Vicente Bergas
2013-11-24 17:51   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-11-24  8:37 ` [PATCH 1/2] OMAP4: fix writel data/address swap regression Alexander Aring
2013-11-25  7:31 ` Sascha Hauer
2013-11-25  7:34   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131124175105.GB29652@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=vicencb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox