From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Vicente Bergas <vicencb@gmail.com>
Subject: Re: [PATCH 1/2] OMAP4: fix writel data/address swap regression
Date: Mon, 25 Nov 2013 08:34:54 +0100 [thread overview]
Message-ID: <20131125073453.GA26532@omega> (raw)
In-Reply-To: <20131125073143.GN24559@pengutronix.de>
On Mon, Nov 25, 2013 at 08:31:44AM +0100, Sascha Hauer wrote:
> On Sat, Nov 23, 2013 at 08:58:23PM +0100, Vicente Bergas wrote:
> > ---
> > arch/arm/mach-omap/omap4_clock.c | 176 +++++++++++++++++++--------------------
> > 1 file changed, 88 insertions(+), 88 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap/omap4_clock.c b/arch/arm/mach-omap/omap4_clock.c
> > index 268f7c1..72f72a1 100644
> > --- a/arch/arm/mach-omap/omap4_clock.c
> > +++ b/arch/arm/mach-omap/omap4_clock.c
> > @@ -89,7 +89,7 @@ void omap4_configure_per_dpll(const struct dpll_param *dpll_param)
> > void omap4_configure_abe_dpll(const struct dpll_param *dpll_param)
> > {
> > /* Select sys_clk as ref clk for ABE dpll */
> > - writel(CM_ABE_PLL_REF_CLKSEL, 0x0);
> > + writel(0x0, CM_ABE_PLL_REF_CLKSEL);
>
> What a silly bug! Who messed this up? Damn. me :(. Applied both, thanks
>
Yea, I will put this on my list what I should ever check on patches with
writel. :-)
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-11-25 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 19:58 Vicente Bergas
2013-11-23 19:58 ` [PATCH 2/2] OMAP4: fix omap4_bootsource regression Vicente Bergas
2013-11-24 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-24 8:37 ` [PATCH 1/2] OMAP4: fix writel data/address swap regression Alexander Aring
2013-11-25 7:31 ` Sascha Hauer
2013-11-25 7:34 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125073453.GA26532@omega \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox