[PATCH] of: gpio: Add Kconfig variable to depend on

[PATCH] of: gpio: Add Kconfig variable to depend on

[Sascha Hauer]

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/of/Kconfig  | 5 +++++
 drivers/of/Makefile | 2 +-
 include/of_gpio.h   | 6 +++---
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 6b893d7..cdf7ac7 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -19,6 +19,11 @@ config OF_NET
 	depends on NET
 	def_bool y
 
+config OF_GPIO
+	depends on CONFIG_GPIOLIB
+	depends on CONFIG_OFDEVICE
+	def_bool y
+
 config OF_BAREBOX_DRIVERS
 	depends on OFDEVICE
 	depends on ENV_HANDLING
diff --git a/drivers/of/Makefile b/drivers/of/Makefile
index a19a8af..c883e51 100644
--- a/drivers/of/Makefile
+++ b/drivers/of/Makefile
@@ -1,6 +1,6 @@
 obj-y += address.o base.o fdt.o platform.o
 obj-$(CONFIG_OFTREE_MEM_GENERIC) += mem_generic.o
-obj-$(CONFIG_GPIOLIB) += of_gpio.o
+obj-$(CONFIG_OF_GPIO) += of_gpio.o
 obj-y += partition.o
 obj-y += of_net.o
 obj-$(CONFIG_MTD) += of_mtd.o
diff --git a/include/of_gpio.h b/include/of_gpio.h
index 50536a8..d42b18e 100644
--- a/include/of_gpio.h
+++ b/include/of_gpio.h
@@ -21,11 +21,11 @@ enum of_gpio_flags {
 	OF_GPIO_ACTIVE_LOW = 0x1,
 };
 
-#ifdef CONFIG_OFTREE
+#ifdef CONFIG_OF_GPIO
 extern int of_get_named_gpio_flags(struct device_node *np,
 		const char *list_name, int index, enum of_gpio_flags *flags);
 
-#else /* CONFIG_OFTREE */
+#else /* CONFIG_OF_GPIO */
 
 static inline int of_get_named_gpio_flags(struct device_node *np,
 		const char *list_name, int index, enum of_gpio_flags *flags)
@@ -33,7 +33,7 @@ static inline int of_get_named_gpio_flags(struct device_node *np,
 	return -ENOSYS;
 }
 
-#endif /* CONFIG_OFTREE */
+#endif /* CONFIG_OF_GPIO */
 
 static inline int of_get_named_gpio(struct device_node *np,
 				const char *list_name, int index)
-- 
1.8.4.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] of: gpio: Add Kconfig variable to depend on

[Alexander Aring]

Hi Sascha,

On Fri, Nov 22, 2013 at 03:55:22PM +0100, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/of/Kconfig  | 5 +++++
>  drivers/of/Makefile | 2 +-
>  include/of_gpio.h   | 6 +++---
>  3 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 6b893d7..cdf7ac7 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -19,6 +19,11 @@ config OF_NET
>  	depends on NET
>  	def_bool y
>  
> +config OF_GPIO
> +	depends on CONFIG_GPIOLIB
> +	depends on CONFIG_OFDEVICE
> +	def_bool y

On current next branch the "def_bool y" is missing, so I get:

drivers/of/Kconfig:22:warning: config symbol defined without type

I will send a patch soon...

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] of: gpio: Add Kconfig variable to depend on

[Sascha Hauer]

On Sat, Nov 23, 2013 at 07:21:38AM +0100, Alexander Aring wrote:
> Hi Sascha,
> 
> On Fri, Nov 22, 2013 at 03:55:22PM +0100, Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  drivers/of/Kconfig  | 5 +++++
> >  drivers/of/Makefile | 2 +-
> >  include/of_gpio.h   | 6 +++---
> >  3 files changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> > index 6b893d7..cdf7ac7 100644
> > --- a/drivers/of/Kconfig
> > +++ b/drivers/of/Kconfig
> > @@ -19,6 +19,11 @@ config OF_NET
> >  	depends on NET
> >  	def_bool y
> >  
> > +config OF_GPIO
> > +	depends on CONFIG_GPIOLIB
> > +	depends on CONFIG_OFDEVICE
> > +	def_bool y
> 
> On current next branch the "def_bool y" is missing, so I get:
> 
> drivers/of/Kconfig:22:warning: config symbol defined without type
> 
> I will send a patch soon...

I fixed this by using the correct patch. The wrong one leaked in by
accident.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox