mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] serial: add missing depends on ARCH_ZYNQ
Date: Fri, 6 Dec 2013 13:18:29 +0100	[thread overview]
Message-ID: <20131206121829.GA22558@omega> (raw)
In-Reply-To: <20131206115955.GA21997@omega>

On Fri, Dec 06, 2013 at 12:59:55PM +0100, Alexander Aring wrote:
> Hi Steffen,
> 
> On Fri, Dec 06, 2013 at 10:07:32AM +0100, Steffen Trumtrar wrote:
> > Hi!
> > 
> > On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote:
> > > The cadence serial driver is some ARCH_ZYNQ specific driver.
> > > Add a depends on ARCH_ZYNQ for this driver.
> > > 
> > > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > ---
> > >  drivers/serial/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > > index 11fc155..d520dda 100644
> > > --- a/drivers/serial/Kconfig
> > > +++ b/drivers/serial/Kconfig
> > > @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
> > >  
> > >  config DRIVER_SERIAL_CADENCE
> > >  	bool "Cadence UART driver"
> > > +	depends on ARCH_ZYNQ
> > >  	help
> > >  	  Say Y here if you have a Cadence serial IP core.
> > >  
> > > -- 
> > > 1.8.4.2
> > > 
> > > 
> > > _______________________________________________
> > > barebox mailing list
> > > barebox@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/barebox
> > > 
> > 
> > Does is not compile with other archs?
> > This is intended to be a generic driver; Zynq just happens to be the only user.
> > -> It should not depend on ARCH_ZYNQ.
> 
> oh, I first figure out a depends on COMMON_CLK was missing and though
> that this driver is a platform specific driver.
> 
> When it's a generic driver we should add a "depends on COMMON_CLK"

or for this case a "select COMMON_CLK" would be better. :-)

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-12-06 12:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 23:28 Alexander Aring
2013-12-06  9:07 ` Steffen Trumtrar
2013-12-06 11:59   ` Alexander Aring
2013-12-06 12:18     ` Alexander Aring [this message]
2013-12-09  7:24   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131206121829.GA22558@omega \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox