From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VouMy-0003Je-2Y for barebox@lists.infradead.org; Fri, 06 Dec 2013 12:18:56 +0000 Received: by mail-we0-f182.google.com with SMTP id q59so550181wes.41 for ; Fri, 06 Dec 2013 04:18:34 -0800 (PST) Date: Fri, 6 Dec 2013 13:18:29 +0100 From: Alexander Aring Message-ID: <20131206121829.GA22558@omega> References: <1386199691-12032-1-git-send-email-alex.aring@gmail.com> <20131206090732.GA28174@pengutronix.de> <20131206115955.GA21997@omega> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131206115955.GA21997@omega> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] serial: add missing depends on ARCH_ZYNQ To: Steffen Trumtrar Cc: barebox@lists.infradead.org On Fri, Dec 06, 2013 at 12:59:55PM +0100, Alexander Aring wrote: > Hi Steffen, > > On Fri, Dec 06, 2013 at 10:07:32AM +0100, Steffen Trumtrar wrote: > > Hi! > > > > On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote: > > > The cadence serial driver is some ARCH_ZYNQ specific driver. > > > Add a depends on ARCH_ZYNQ for this driver. > > > > > > Signed-off-by: Alexander Aring > > > --- > > > drivers/serial/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > > > index 11fc155..d520dda 100644 > > > --- a/drivers/serial/Kconfig > > > +++ b/drivers/serial/Kconfig > > > @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT > > > > > > config DRIVER_SERIAL_CADENCE > > > bool "Cadence UART driver" > > > + depends on ARCH_ZYNQ > > > help > > > Say Y here if you have a Cadence serial IP core. > > > > > > -- > > > 1.8.4.2 > > > > > > > > > _______________________________________________ > > > barebox mailing list > > > barebox@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/barebox > > > > > > > Does is not compile with other archs? > > This is intended to be a generic driver; Zynq just happens to be the only user. > > -> It should not depend on ARCH_ZYNQ. > > oh, I first figure out a depends on COMMON_CLK was missing and though > that this driver is a platform specific driver. > > When it's a generic driver we should add a "depends on COMMON_CLK" or for this case a "select COMMON_CLK" would be better. :-) - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox