mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robert Schwebel <r.schwebel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: i.MX6: tqma6x: dts: move FEC enablement to baseboard
Date: Mon, 9 Dec 2013 09:29:45 +0100	[thread overview]
Message-ID: <20131209082945.GJ24559@pengutronix.de> (raw)
In-Reply-To: <1386357468-26892-2-git-send-email-r.schwebel@pengutronix.de>

On Fri, Dec 06, 2013 at 08:17:46PM +0100, Robert Schwebel wrote:
> The definition if the FEC is used is made by the baseboard (MBa6x), not
> by the module (TQMa6x). Move it there.
> 
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  arch/arm/dts/imx6q-mba6x.dts  | 4 ++++
>  arch/arm/dts/imx6q-tqma6x.dts | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/imx6q-mba6x.dts b/arch/arm/dts/imx6q-mba6x.dts
> index 69d46b4..e057fc4 100644
> --- a/arch/arm/dts/imx6q-mba6x.dts
> +++ b/arch/arm/dts/imx6q-mba6x.dts
> @@ -26,6 +26,10 @@
>  	};
>  };
>  
> +&fec {
> +	status = "okay";
> +};
> +

This is the wrong file, it's the baseboard for the i.MX6q module only.
Added it to imx6qdl-mba6x.dtsi instead.

>  &iomuxc {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_hog>;
> diff --git a/arch/arm/dts/imx6q-tqma6x.dts b/arch/arm/dts/imx6q-tqma6x.dts
> index 597388e..f556381 100644
> --- a/arch/arm/dts/imx6q-tqma6x.dts
> +++ b/arch/arm/dts/imx6q-tqma6x.dts
> @@ -81,7 +81,7 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet_1>;
>  	phy-mode = "rgmii";
> -	status = "okay";
> +	status = "disabled";

This is the file you remove in 3/3. Applied this change to
imx6qdl-tqma6x.dtsi instead.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-12-09  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 19:17 DTS patches Robert Schwebel
2013-12-06 19:17 ` [PATCH 1/3] ARM: i.MX6: tqma6x: dts: move FEC enablement to baseboard Robert Schwebel
2013-12-09  8:29   ` Sascha Hauer [this message]
2013-12-06 19:17 ` [PATCH 2/3] ARM: i.MX6: tqma6x: dts: get MAC address from OCOTP Robert Schwebel
2013-12-06 19:17 ` [PATCH 3/3] ARM: i.MX6: tqma6x: dts: remove unused dts file Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131209082945.GJ24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.schwebel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox