mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Eric B??nard <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/7] atmel_nand: check gpio validity before using it
Date: Mon, 9 Dec 2013 14:34:36 +0100	[thread overview]
Message-ID: <20131209133436.GL27628@ns203013.ovh.net> (raw)
In-Reply-To: <1386409020-11914-1-git-send-email-eric@eukrea.com>

On 10:36 Sat 07 Dec     , Eric B??nard wrote:
> else we get : "invalid GPIO -22"
> (as enable_pin is EINVAL)
> 
> tested on SAMA5D35

Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  drivers/mtd/nand/atmel_nand.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index a0f0966..658ae52 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -107,7 +107,7 @@ static struct nand_ecclayout atmel_pmecc_oobinfo;
>   */
>  static void atmel_nand_enable(struct atmel_nand_host *host)
>  {
> -	if (host->board->enable_pin)
> +	if (gpio_is_valid(host->board->enable_pin))
>  		gpio_set_value(host->board->enable_pin, 0);
>  }
>  
> @@ -116,7 +116,7 @@ static void atmel_nand_enable(struct atmel_nand_host *host)
>   */
>  static void atmel_nand_disable(struct atmel_nand_host *host)
>  {
> -	if (host->board->enable_pin)
> +	if (gpio_is_valid(host->board->enable_pin))
>  		gpio_set_value(host->board->enable_pin, 1);
>  }
>  
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2013-12-09 13:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07  9:36 Eric Bénard
2013-12-07  9:36 ` [PATCH 2/7] at91: introduce sama5d3's SMC support Eric Bénard
2013-12-09 13:27   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-12  8:51     ` Sascha Hauer
2013-12-12  9:53       ` Eric Bénard
2013-12-07  9:36 ` [PATCH 3/7] at91: sama5d3: use the sama5 smc instead of the sam9 one Eric Bénard
2013-12-09 13:28   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-07  9:36 ` [PATCH 4/7] sama5d3xek: update nand timings Eric Bénard
2013-12-07  9:36 ` [PATCH 5/7] atmel_nand: make chip_delay configurable Eric Bénard
2013-12-09 13:30   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-09 14:54     ` Eric Bénard
2013-12-09 16:32       ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-09 16:57         ` Eric Bénard
2013-12-09 17:15         ` Eric Bénard
2013-12-10  7:25           ` Sascha Hauer
2013-12-07  9:36 ` [PATCH 6/7] sama5d3xek: add NOR CFI support Eric Bénard
2013-12-09 13:37   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-12  8:57     ` Sascha Hauer
2013-12-12  9:52       ` Eric Bénard
2013-12-07  9:37 ` [PATCH 7/7] samsa5d3xek: update defconfig Eric Bénard
2013-12-09 13:31   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-09 14:53     ` Eric Bénard
2013-12-09 16:33       ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-09 16:48       ` Alexander Aring
2013-12-09  8:36 ` [PATCH 1/7] atmel_nand: check gpio validity before using it Sascha Hauer
2013-12-09 13:31   ` Jean-Christophe PLAGNIOL-VILLARD
2013-12-09 13:34 ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131209133436.GL27628@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox