From: Antony Pavlov <antonynpavlov@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [JUST RFC] ARM: DIGIC: add csrc-dummy
Date: Sun, 15 Dec 2013 22:52:18 +0400 [thread overview]
Message-ID: <20131215225218.0185e701c5bef4889559a65d@gmail.com> (raw)
In-Reply-To: <1387130880.154942460@f379.i.mail.ru>
On Sun, 15 Dec 2013 22:08:00 +0400
Alexander Shiyan <shc_work@mail.ru> wrote:
> > The clocksource csrc-timer driver that uses DIGIC
> > hardware TIMER2 perfectrly works on Canon A1100,
> > but does not works on Canon EOS 600D.
> > IMHO we need additional timer initialisation.
> >
> > This patch introduces a quick-and-dirty termporary
> > solution for this situation: a clocksource driver that
> > does not use any hardware at all.
> >
> > Also this driver is very handy for running barebox
> > on Magic Lantern EOS qemu-based emulator as
> > the emulator does not realize timer counter register at all!
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ...
> > + printf("clocksource_init: mult=%08x, shift=%08x\n",
> > + dummy_cs.mult, dummy_cs.shift);
>
> No reason to spam into console. Put this into pr_debug.
>
Of cause there is no reason to spam into console!
This patch is mailed only for illustration of the concept,
it even can't be applyed.
Have you any comments on the concept itself?
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-12-15 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 15:02 [JUST RFC] add hardware independent clock source Antony Pavlov
2013-12-15 15:02 ` [JUST RFC] ARM: DIGIC: add csrc-dummy Antony Pavlov
2013-12-15 18:08 ` Alexander Shiyan
2013-12-15 18:52 ` Antony Pavlov [this message]
2013-12-15 18:50 ` Alexander Shiyan
2013-12-15 19:30 ` Alexander Aring
2013-12-15 20:40 ` Antony Pavlov
2013-12-15 21:17 ` Alexander Aring
2013-12-16 7:41 ` Sascha Hauer
2013-12-16 7:46 ` Alexander Aring
2013-12-16 7:48 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131215225218.0185e701c5bef4889559a65d@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox