mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: fix wrong return values in cdev read
Date: Fri, 20 Dec 2013 15:06:44 +0100	[thread overview]
Message-ID: <20131220140644.GA24559@pengutronix.de> (raw)
In-Reply-To: <1387466483-16353-1-git-send-email-s.hauer@pengutronix.de>

On Thu, Dec 19, 2013 at 04:21:23PM +0100, Sascha Hauer wrote:
> mtd->read returns the number of bitflips as positive numbers.
> Instead of returning these numbers Return -EUCLEAN when the bitflip
> threshold has been reached, 0 otherwise.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/mtd/core.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
> index f63b10e..57b0fad 100644
> --- a/drivers/mtd/core.c
> +++ b/drivers/mtd/core.c
> @@ -74,12 +74,11 @@ static ssize_t mtd_op_read(struct cdev *cdev, void* buf, size_t count,
>  			offset, count);
>  
>  	ret = mtd_read(mtd, offset, count, &retlen, buf);
> -
> -	if(ret) {
> -		printf("err %d\n", ret);
> +	if (ret < 0)
>  		return ret;
> -	}
> -	return retlen;
> +	if (mtd->ecc_strength == 0)
> +		return 0;	/* device lacks ecc */
> +	return ret >= mtd->bitflip_threshold ? -EUCLEAN : 0;

This is not correct. We have to return retlen, not 0. Will resend along
with some other fixes.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-12-20 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 15:21 Sascha Hauer
2013-12-20 14:06 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131220140644.GA24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox