November spi changes

November spi changes

[Antony Pavlov]

Hi!

I'm working on adding SPI driver for Atheros 933x.

I'm using this code for registering spi flash:

=========================================================
static struct flash_platform_data spi_boot_flash_data = {
	.name		= "spi",
	.type		= "s25sl032p",
};

static struct spi_board_info spi_devs[] __initdata = {
	{
		/* boot: Spansion S25FL032P SPI flash */
		.name		= "m25p80",
		.max_speed_hz	= 104 * 1000 * 1000,
		.bus_num	= 0,
		.chip_select	= 0,
		.mode		= SPI_MODE_3,
		.platform_data	= &spi_boot_flash_data,
	},
};

...

	spi_register_board_info(spi_devs, ARRAY_SIZE(spi_devs));
=========================================================

If I rebase Atheros 933x over barebox-2013.11.0 then this code
works fine.

If I rebase Atheros 933x over barebox-2013.12.0 then I get
"Ooops" in get_param_by_name(dev=spi, name=size)

=========================================
Board: TP Link WR720N
m25p80 m25p800: s25sl032p (4096 Kbytes)
register_device: already registered spi

Ooops, TLB miss on load or ifetch!

...

### ERROR ### Please RESET the board ###
=========================================

Changing this

=========================================================
static struct flash_platform_data spi_boot_flash_data = {
	.name		= "spi",
	.type		= "s25sl032p",
};
=========================================================

to

=========================================================
static struct flash_platform_data spi_boot_flash_data = {
	.name		= "spi0",
	.type		= "s25sl032p",
};
=========================================================

solves the problem.

Sascha, please, comment this message.

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: November spi changes

[Sascha Hauer]

Hi Antony,

> 
> If I rebase Atheros 933x over barebox-2013.12.0 then I get
> "Ooops" in get_param_by_name(dev=spi, name=size)
> 
> =========================================
> Board: TP Link WR720N
> m25p80 m25p800: s25sl032p (4096 Kbytes)
> register_device: already registered spi

This seems to be your problem,

> 
> Ooops, TLB miss on load or ifetch!

This probably results from add_mtd_device() failling to check the return
value of register_device() properly.

> =========================================================
> static struct flash_platform_data spi_boot_flash_data = {
> 	.name		= "spi",
> 	.type		= "s25sl032p",
> };
> =========================================================
> 
> to
> 
> =========================================================
> static struct flash_platform_data spi_boot_flash_data = {
> 	.name		= "spi0",
> 	.type		= "s25sl032p",
> };
> =========================================================

The .name field defines the device filename under /dev. I would use
something like "spiflash0" here. "spi" or "spi0" sounds more like a spi
bus and in fact the it's already used by the spi bus.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox