From: Santosh Sivaraj <santosh@fossix.org>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Make number of GPT partitions a configurable option
Date: Thu, 9 Jan 2014 21:59:33 +0530 [thread overview]
Message-ID: <20140109162933.GC7102@san0.fossix.org> (raw)
In-Reply-To: <20140109160641.GA7102@san0.fossix.org>
* Santosh Sivaraj <santosh@fossix.org> wrote (on 2014-01-09 21:36:41 +0530):
adding list, missed it.
> * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote (on 2014-01-09 08:29:14 +0100):
>
> > On 15:07 Wed 08 Jan , Sascha Hauer wrote:
> > > Hi Santosh,
> > >
> > > On Wed, Jan 08, 2014 at 08:15:39AM +0530, Santosh Sivaraj wrote:
> > > > Theoritically there is no limit for the partitions that can be created
> > > > based on EFI/GPT, so make the number of partitions that can be visible
> > > > in barebox a configurable option.
> > > >
> > > > Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> > > > ---
> > > > common/partitions/Kconfig | 5 +++++
> > > > common/partitions/parser.h | 2 +-
> > > > 2 files changed, 6 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/common/partitions/Kconfig b/common/partitions/Kconfig
> > > > index 90238ad..f3353dd 100644
> > > > --- a/common/partitions/Kconfig
> > > > +++ b/common/partitions/Kconfig
> > > > @@ -31,3 +31,8 @@ config PARTITION_DISK_EFI_GPT_COMPARE
> > > > depends on PARTITION_DISK_EFI
> > > > default y
> > > > bool "EFI: GPT: compare primary and Alternate GPT header for validity"
> > > > +
> > > > +config MAX_PARTITIONS
> > > > + depends on PARTITION_DISK_EFI
> > > > + int "Maximum of partitions needed to be supported on a GPT"
> > > > + default 8
> > >
> > > Can we instead allocate the partitions dynamically? This limitation to
> > > eight partitions we currently have is not nice, but making it
> > > configurable is not a proper fix.
> >
> > agreed but a limit will be good too
> >
> > Best Regards,
> > J.
> > >
> > > Sascha
> > >
>
> We could keep a configurable maximum, with a high default, but do the allocation
> dynamically. I will try to send in a patch, we can discuss how it needs to be
> done over it.
>
> Thanks,
> Santosh
--
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-01-09 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 2:45 Santosh Sivaraj
2014-01-08 14:07 ` Sascha Hauer
2014-01-09 7:29 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20140109160641.GA7102@san0.fossix.org>
2014-01-09 16:29 ` Santosh Sivaraj [this message]
2014-01-10 8:02 ` Sascha Hauer
2014-01-10 8:24 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-10 8:49 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109162933.GC7102@san0.fossix.org \
--to=santosh@fossix.org \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox