From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W2zgv-0004kx-4G for barebox@lists.infradead.org; Tue, 14 Jan 2014 08:49:46 +0000 Received: by mail-we0-f179.google.com with SMTP id w62so78918wes.38 for ; Tue, 14 Jan 2014 00:49:22 -0800 (PST) Date: Tue, 14 Jan 2014 09:49:17 +0100 From: Alexander Aring Message-ID: <20140114084916.GA26300@omega> References: <1389687817-30882-1-git-send-email-list-09_barebox@tqsc.de> <1389687817-30882-4-git-send-email-list-09_barebox@tqsc.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1389687817-30882-4-git-send-email-list-09_barebox@tqsc.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/4] mci: imx-esdhc: add DSR support To: Markus Niebel Cc: barebox@lists.infradead.org, Markus Niebel Hi, On Tue, Jan 14, 2014 at 09:23:36AM +0100, Markus Niebel wrote: > From: Markus Niebel > > having DSR support in mci-core we need a way to > forward the DSR value to the driver. Add it to > platform data for imx-esdhc > > TODO: implement the same for other host controller > drivers > > Signed-off-by: Markus Niebel > --- > arch/arm/mach-imx/include/mach/esdhc.h | 2 ++ > drivers/mci/imx-esdhc.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-imx/include/mach/esdhc.h b/arch/arm/mach-imx/include/mach/esdhc.h > index add1691..fb7380a 100644 > --- a/arch/arm/mach-imx/include/mach/esdhc.h > +++ b/arch/arm/mach-imx/include/mach/esdhc.h > @@ -42,5 +42,7 @@ struct esdhc_platform_data { > enum cd_types cd_type; > unsigned caps; > char *devname; > + unsigned dsr_val; > + int use_dsr; > }; > #endif /* __ASM_ARCH_IMX_ESDHC_H */ > diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c > index 7664e7b..4c7a45e 100644 > --- a/drivers/mci/imx-esdhc.c > +++ b/drivers/mci/imx-esdhc.c > @@ -582,6 +582,10 @@ static int fsl_esdhc_probe(struct device_d *dev) > if (host->mci.f_min < 200000) > host->mci.f_min = 200000; > host->mci.f_max = rate; > + if (pdata) { > + host->mci.use_dsr = pdata->use_dsr; > + host->mci.dsr_val = pdata->dsr_val; > + } > I don't know what other barebox devs thinking about this. But I would remove use_dsr attribute, because a dsr_val != 0 indicates that you want to use dsr. You don't need a extra switch, in my opinion. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox