From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W4bO3-0001Z7-53 for barebox@lists.infradead.org; Sat, 18 Jan 2014 19:16:56 +0000 Received: by mail-wg0-f49.google.com with SMTP id a1so5572291wgh.4 for ; Sat, 18 Jan 2014 11:16:29 -0800 (PST) Date: Sat, 18 Jan 2014 20:16:27 +0100 From: Alexander Aring Message-ID: <20140118191625.GB3624@omega> References: <1389971012-22977-1-git-send-email-s.hauer@pengutronix.de> <1389971012-22977-3-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1389971012-22977-3-git-send-email-s.hauer@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 02/22] ARM: phyCARD-i.MX27: increase barebox partition To: Sascha Hauer Cc: barebox@lists.infradead.org Hi, On Fri, Jan 17, 2014 at 04:03:12PM +0100, Sascha Hauer wrote: > More place for barebox. > > Signed-off-by: Sascha Hauer > --- > arch/arm/boards/phycard-i.MX27/env/config | 2 +- > arch/arm/boards/phycard-i.MX27/pca100.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boards/phycard-i.MX27/env/config b/arch/arm/boards/phycard-i.MX27/env/config > index 9596311..9f10e7d 100644 > --- a/arch/arm/boards/phycard-i.MX27/env/config > +++ b/arch/arm/boards/phycard-i.MX27/env/config > @@ -39,7 +39,7 @@ autoboot_timeout=3 > > bootargs="console=ttymxc0,115200" > > -nand_parts="256k(barebox)ro,128k(bareboxenv),2M(kernel),-(root)" > +nand_parts="512k(barebox)ro,512k(bareboxenv),2M(kernel),-(root)" First I through "2 MB for kernel?", but then I see you change this to 4MB in another patch which introduce the new barebox env, so thats pretty cool. :-) > rootfs_mtdblock_nand=7 > > # set a fancy prompt (if support is compiled in) > diff --git a/arch/arm/boards/phycard-i.MX27/pca100.c b/arch/arm/boards/phycard-i.MX27/pca100.c > index 2ff1b79..7ac0bf6 100644 > --- a/arch/arm/boards/phycard-i.MX27/pca100.c > +++ b/arch/arm/boards/phycard-i.MX27/pca100.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -287,10 +288,10 @@ static int pca100_devices_init(void) > #endif > > nand = get_device_by_name("nand0"); I know, you don't make any change here but I though "What the hell do this function here? Increase some reference count, because nand is never used in this function?" Then I look a little bit deeper and it simple does nothing... - Maybe we should remove this and the nand variable? It's only a small hint which I detected. - Alex _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox