mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 13/15] ARM: i.MX25: Karo TX25: Switch to devicetree support
Date: Sat, 1 Feb 2014 19:37:31 +0100	[thread overview]
Message-ID: <20140201183731.GD16215@pengutronix.de> (raw)
In-Reply-To: <1391279099.419129086@f198.i.mail.ru>

On Sat, Feb 01, 2014 at 10:24:59PM +0400, Alexander Shiyan wrote:
> Суббота,  1 февраля 2014, 19:13 +01:00 от Sascha Hauer <s.hauer@pengutronix.de>:
> > On Fri, Jan 31, 2014 at 06:35:36PM +0400, Alexander Shiyan wrote:
> > > Пятница, 31 января 2014, 15:23 +01:00 от Sascha Hauer
> > <s.hauer@pengutronix.de>:
> > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > > ---
> > > > arch/arm/boards/karo-tx25/board.c   | 130
> > ++++++++++--------------------------
> > > ...
> > > > #define TX25_FEC_PWR_GPIO	IMX_GPIO_NR(4, 9)
> > > > #define TX25_FEC_RST_GPIO	IMX_GPIO_NR(4, 7)
> > > > 
> > > > +static struct gpio fec_gpios[] = {
> > > > +	{
> > > > +		.gpio = TX25_FEC_PWR_GPIO,
> > > > +		.flags = GPIOF_OUT_INIT_LOW,
> > > > +		.label = "fec-pwr",
> > > > +	}, {
> > > > +		.gpio = TX25_FEC_RST_GPIO,
> > > > +		.flags = GPIOF_OUT_INIT_LOW,
> > > > +		.label = "fec-rst",
> > > > +	},
> > > > +};
> > > 
> > > You have added these pins to DTS in PATCH 08/15.
> > > What a reason to setup it twice?
> > 
> > 08/15 only adds the pinctrl nodes. The code here is to power on the phy
> > as we do not have regulator support yet.
> 
> Ok, I agree about PWR pin, but what about RST? Afaik we can handle
> it from the FEC driver code.

It is handled in the FEC driver code. The code above just makes sure
that the phy is still in reset after it's powered up. The reset is then
released later in the FEC driver.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-01 18:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31 14:23 i.MX25 " Sascha Hauer
2014-01-31 14:23 ` [PATCH 01/15] mci: imx-esdhc: Add i.MX25 compatible entry Sascha Hauer
2014-01-31 14:23 ` [PATCH 02/15] ARM: dts: Add i.MX25 devicetree files Sascha Hauer
2014-01-31 14:23 ` [PATCH 03/15] ARM: dts: i.MX25: Add mmc aliases Sascha Hauer
2014-01-31 14:23 ` [PATCH 04/15] ARM: dts: i.MX25: remove disabled status of usbmisc unit Sascha Hauer
2014-01-31 14:23 ` [PATCH 05/15] ARM: i.MX25: Add missing GPT clock lookups Sascha Hauer
2014-01-31 14:23 ` [PATCH 06/15] ARM: dts: Add i.MX25 Karo TX25 dts Sascha Hauer
2014-01-31 14:23 ` [PATCH 07/15] ARM: dts: i.MX25: Add iram to devicetree Sascha Hauer
2014-01-31 14:23 ` [PATCH 08/15] ARM: dts: Karo TX25: Add pinctrl nodes Sascha Hauer
2014-01-31 14:23 ` [PATCH 09/15] ARM: dts: Karo TX25: Add phy-reset-gpio Sascha Hauer
2014-01-31 14:23 ` [PATCH 10/15] ARM: dts: Karo TX25: add missing nfc properties Sascha Hauer
2014-01-31 14:23 ` [PATCH 11/15] ARM: dts: Karo TX25: add phy supply for fec Sascha Hauer
2014-01-31 14:23 ` [PATCH 12/15] ARM: dts: Karo TX25: add barebox specifics Sascha Hauer
2014-01-31 14:23 ` [PATCH 13/15] ARM: i.MX25: Karo TX25: Switch to devicetree support Sascha Hauer
2014-01-31 14:35   ` Alexander Shiyan
2014-02-01 18:13     ` Sascha Hauer
2014-02-01 18:24       ` Alexander Shiyan
2014-02-01 18:37         ` Sascha Hauer [this message]
2014-01-31 14:23 ` [PATCH 14/15] ARM: i.MX: cleanup bootmode selection Sascha Hauer
2014-01-31 14:23 ` [PATCH 15/15] ARM: i.MX: Karo TX25: Switch to multiboard support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140201183731.GD16215@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox