mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org, David Vincent <freesilicon@gmail.com>
Subject: Re: [PATCH] Load PBL into SRAM
Date: Tue, 4 Feb 2014 08:04:29 +0100	[thread overview]
Message-ID: <20140204070429.GL16215@pengutronix.de> (raw)
In-Reply-To: <20140204065745.GK16215@pengutronix.de>

On Tue, Feb 04, 2014 at 07:57:46AM +0100, Sascha Hauer wrote:
> On Tue, Feb 04, 2014 at 04:56:25AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:06 Fri 31 Jan     , David Vincent wrote:
> > > This allows to load all the lowlevel init code, including the
> > > uncompressor, inside SRAM and not just the bare init part. This is
> > > useful when pbl is used as a first-stage bootloader but is loaded by an
> > > external firmware.
> > > 
> > > Signed-off-by: David Vincent <freesilicon@gmail.com>
> > > ---
> > >  arch/arm/lib/pbl.lds.S            |    4 ++--
> > >  common/Kconfig                    |   16 ++++++++++++++--
> > >  include/asm-generic/barebox.lds.h |   14 +++++++++++++-
> > >  pbl/Kconfig                       |    7 +++++++
> > >  4 files changed, 36 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/arch/arm/lib/pbl.lds.S b/arch/arm/lib/pbl.lds.S
> > > index 0954c89..34c0cb3 100644
> > > --- a/arch/arm/lib/pbl.lds.S
> > > +++ b/arch/arm/lib/pbl.lds.S
> > > @@ -50,11 +50,11 @@ SECTIONS
> > >  		*(.text*)
> > >  	}
> > >  
> > > +	BAREBOX_PBL_SIZE
> > > +
> > >  	/* Discard unwind if enable in barebox */
> > >  	/DISCARD/ : { *(.ARM.ex*) }
> > >  
> > > -	BAREBOX_BARE_INIT_SIZE
> > > -
> > 
> > nack you change the binary format you can add an information but can not
> > change the format
> 
> I don't think the format is changed here. It shouldn't matter where the
> /DISCARD/ is, right? Nevertheless the patch looks more obvious if just
> the line is changed, not its position.

Sorry, I misread the patch. My thought was that BAREBOX_PBL_SIZE
replaces (and includes) BAREBOX_BARE_INIT_SIZE, but this is not the
case. So you are right, BAREBOX_BARE_INIT_SIZE should not be removed
here.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-04  7:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31  9:06 David Vincent
2014-02-03  8:12 ` Sascha Hauer
     [not found]   ` <CAKRNOGz68GEnwU_qEu28xJHBuDsaird4qnepB6rHv48EGdMBOw@mail.gmail.com>
2014-02-03  9:58     ` Fwd: " David Vincent
2014-02-04  7:05       ` Sascha Hauer
2014-02-04  7:51         ` David Vincent
2014-02-04  3:56 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-04  6:57   ` Sascha Hauer
2014-02-04  7:04     ` Sascha Hauer [this message]
2014-02-04  7:49     ` David Vincent
2014-02-05  8:00       ` Sascha Hauer
2014-02-05 12:48         ` David Vincent
2014-02-05 15:45           ` Sascha Hauer
2014-02-20 16:32             ` David Vincent
2014-02-04  7:51   ` David Vincent
  -- strict thread matches above, loose matches on Subject: below --
2014-02-04  7:53 David Vincent
2014-01-30 15:43 David Vincent
2014-01-31  6:51 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204070429.GL16215@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=freesilicon@gmail.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox