From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAa3v-0005gJ-O4 for barebox@lists.infradead.org; Tue, 04 Feb 2014 07:04:52 +0000 Date: Tue, 4 Feb 2014 08:04:29 +0100 From: Sascha Hauer Message-ID: <20140204070429.GL16215@pengutronix.de> References: <1391159170-17686-1-git-send-email-freesilicon@gmail.com> <20140204035625.GE9671@ns203013.ovh.net> <20140204065745.GK16215@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140204065745.GK16215@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] Load PBL into SRAM To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org, David Vincent On Tue, Feb 04, 2014 at 07:57:46AM +0100, Sascha Hauer wrote: > On Tue, Feb 04, 2014 at 04:56:25AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 10:06 Fri 31 Jan , David Vincent wrote: > > > This allows to load all the lowlevel init code, including the > > > uncompressor, inside SRAM and not just the bare init part. This is > > > useful when pbl is used as a first-stage bootloader but is loaded by an > > > external firmware. > > > > > > Signed-off-by: David Vincent > > > --- > > > arch/arm/lib/pbl.lds.S | 4 ++-- > > > common/Kconfig | 16 ++++++++++++++-- > > > include/asm-generic/barebox.lds.h | 14 +++++++++++++- > > > pbl/Kconfig | 7 +++++++ > > > 4 files changed, 36 insertions(+), 5 deletions(-) > > > > > > diff --git a/arch/arm/lib/pbl.lds.S b/arch/arm/lib/pbl.lds.S > > > index 0954c89..34c0cb3 100644 > > > --- a/arch/arm/lib/pbl.lds.S > > > +++ b/arch/arm/lib/pbl.lds.S > > > @@ -50,11 +50,11 @@ SECTIONS > > > *(.text*) > > > } > > > > > > + BAREBOX_PBL_SIZE > > > + > > > /* Discard unwind if enable in barebox */ > > > /DISCARD/ : { *(.ARM.ex*) } > > > > > > - BAREBOX_BARE_INIT_SIZE > > > - > > > > nack you change the binary format you can add an information but can not > > change the format > > I don't think the format is changed here. It shouldn't matter where the > /DISCARD/ is, right? Nevertheless the patch looks more obvious if just > the line is changed, not its position. Sorry, I misread the patch. My thought was that BAREBOX_PBL_SIZE replaces (and includes) BAREBOX_BARE_INIT_SIZE, but this is not the case. So you are right, BAREBOX_BARE_INIT_SIZE should not be removed here. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox