From: Sascha Hauer <s.hauer@pengutronix.de>
To: David Vincent <freesilicon@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: Fwd: [PATCH] Load PBL into SRAM
Date: Tue, 4 Feb 2014 08:05:38 +0100 [thread overview]
Message-ID: <20140204070537.GM16215@pengutronix.de> (raw)
In-Reply-To: <CAKRNOGzSYsEz-jKE19EjY3gw72usbDhBcMCB6k_Zn=zR_kwwqA@mail.gmail.com>
On Mon, Feb 03, 2014 at 10:58:06AM +0100, David Vincent wrote:
> 2014-02-03 Sascha Hauer <s.hauer@pengutronix.de>:
>
> > On Fri, Jan 31, 2014 at 10:06:10AM +0100, David Vincent wrote:
> > > This allows to load all the lowlevel init code, including the
> > > uncompressor, inside SRAM and not just the bare init part. This is
> > > useful when pbl is used as a first-stage bootloader but is loaded by an
> > > external firmware.
> >
> > Just to make sure I understand this correctly: The patch does not make a
> > code change, all it does is to check that the binary does not get too
> > big, right?
>
>
> Exactly, just like BAREBOX_MAX_BARE_INIT_SIZE but for the whole
> prebootlader code (lowlevel + uncompressor + caches (?) + etc...) not
> just functions marked as __bare_init.
>
> >
> > > +config BAREBOX_MAX_PBL_SIZE
> > > + depends on PBL_IMAGE && LOAD_PBL_SRAM
> > > + prompt "Maximum pre-bootloader size"
> > > + hex
> > > + default 0xffffffff
> > > + help
> > > + Define the maximum size of pbl
> > > + this will allow your pbl to fit in SRAM as example
> > > + ARCH can overwrite it via ARCH_BAREBOX_MAX_PBL_SIZE
> >
> > I stumble upon this 'allow', maybe better something like:
> >
> > On some hardware the ROM code can load the pbl into SRAM, but not the
> > whole image. This option specifies how big the pbl may get.
>
>
> I copied the definition from BAREBOX_MAX_BARE_INIT_SIZE as it shares
> the same goal, but if you find it clearer that way, I can resubmit the
> patch with that definition, it is up to you !
Yes, I think it's clearer and we should use the definition.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-02-04 7:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 9:06 David Vincent
2014-02-03 8:12 ` Sascha Hauer
[not found] ` <CAKRNOGz68GEnwU_qEu28xJHBuDsaird4qnepB6rHv48EGdMBOw@mail.gmail.com>
2014-02-03 9:58 ` Fwd: " David Vincent
2014-02-04 7:05 ` Sascha Hauer [this message]
2014-02-04 7:51 ` David Vincent
2014-02-04 3:56 ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-04 6:57 ` Sascha Hauer
2014-02-04 7:04 ` Sascha Hauer
2014-02-04 7:49 ` David Vincent
2014-02-05 8:00 ` Sascha Hauer
2014-02-05 12:48 ` David Vincent
2014-02-05 15:45 ` Sascha Hauer
2014-02-20 16:32 ` David Vincent
2014-02-04 7:51 ` David Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204070537.GM16215@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=freesilicon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox