From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] scripts/kwbimage: Fix resource leak in image_create()
Date: Tue, 4 Feb 2014 08:21:26 +0100 [thread overview]
Message-ID: <20140204072126.GQ16215@pengutronix.de> (raw)
In-Reply-To: <1391453450-20873-1-git-send-email-shc_work@mail.ru>
On Mon, Feb 03, 2014 at 10:50:49PM +0400, Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Applied both, thanks
Sascha
> ---
> scripts/kwbimage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/kwbimage.c b/scripts/kwbimage.c
> index cd87456..c085d4d 100644
> --- a/scripts/kwbimage.c
> +++ b/scripts/kwbimage.c
> @@ -1343,6 +1343,7 @@ static int image_create(const char *input, const char *output,
> rewind(fcfg);
>
> ret = image_create_config_parse(fcfg, image_cfg, &cfgn);
> + fclose(fcfg);
> if (ret) {
> free(image_cfg);
> return -1;
> --
> 1.8.3.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-02-04 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 18:50 Alexander Shiyan
2014-02-03 18:50 ` [PATCH 2/2] scripts/kwbimage: Fix resource leak in image_create_payload() Alexander Shiyan
2014-02-04 7:21 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204072126.GQ16215@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox