mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 9/9] nfs: parse nfsport and mount port from file system options
Date: Fri, 7 Feb 2014 07:50:32 +0100	[thread overview]
Message-ID: <20140207065032.GG9671@ns203013.ovh.net> (raw)
In-Reply-To: <1391704854-3141-10-git-send-email-u.kleine-koenig@pengutronix.de>

On 17:40 Thu 06 Feb     , Uwe Kleine-K??nig wrote:
> This allows to use unfs3 on the server side which doesn't integrate into
> portmap/rpcbind which results in the port not being impossible to lookup
> via rpc calls to the portmap program.
> 
> Use it like:
> 
> 	mount -t nfs -o port=2703,mountport=2703 192.168.77.157:/root /mnt/nfs
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  fs/nfs.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 51 insertions(+), 11 deletions(-)
> 
> diff --git a/fs/nfs.c b/fs/nfs.c
> index 8eec63078dd3..50b3744b4551 100644
> --- a/fs/nfs.c
> +++ b/fs/nfs.c
> @@ -1305,6 +1305,38 @@ static int nfs_stat(struct device_d *dev, const char *filename, struct stat *s)
>  	}
>  }
>  
> +static void parseopt_hu(const char *options, const char *opt,
> +		unsigned short *val)
> +{
> +	const char *start;
> +	size_t optlen = strlen(opt);
> +	ulong v;
> +	char *endp;
> +
> +again:
> +	start = strstr(options, opt);
> +
> +	if (!start)
> +		return;
> +
> +	if (start > options && start[-1] != ',') {
> +		options = start;
> +		goto again;
> +	}
> +
> +	if (start[optlen] != '=') {
> +		options = start;
> +		goto again;
> +	}
> +
> +	v = simple_strtoul(start + optlen + 1, &endp, 0);
> +	if (v > USHORT_MAX)
> +		return;
> +
> +	if (*endp == ',' || *endp == '\0')
> +		*val = v;
> +}

this should be global
> +
>  static int nfs_probe(struct device_d *dev)
>  {
>  	struct fs_device_d *fsdev = dev_to_fs_device(dev);
> @@ -1340,19 +1372,27 @@ static int nfs_probe(struct device_d *dev)
>  	/* Need a priviliged source port */
>  	net_udp_bind(npriv->con, 1000);
>  
> -	ret = rpc_lookup_req(npriv, PROG_MOUNT, 1);
> -	if (ret < 0) {
> -		printf("lookup mount port failed with %d\n", ret);
> -		goto err2;
> +	parseopt_hu(fsdev->options, "mountport", &npriv->mount_port);
> +	if (!npriv->mount_port) {
> +		ret = rpc_lookup_req(npriv, PROG_MOUNT, 1);
> +		if (ret < 0) {
> +			printf("lookup mount port failed with %d\n", ret);
> +			goto err2;
> +		}
> +		npriv->mount_port = ret;
>  	}
> -	npriv->mount_port = ret;
> -
> -	ret = rpc_lookup_req(npriv, PROG_NFS, 3);
> -	if (ret < 0) {
> -		printf("lookup nfs port failed with %d\n", ret);
> -		goto err2;
> +	debug("mount port: %hu\n", npriv->mount_port);
> +
> +	parseopt_hu(fsdev->options, "port", &npriv->nfs_port);
> +	if (!npriv->nfs_port) {
> +		ret = rpc_lookup_req(npriv, PROG_NFS, 3);
> +		if (ret < 0) {
> +			printf("lookup nfs port failed with %d\n", ret);
> +			goto err2;
> +		}
> +		npriv->nfs_port = ret;
>  	}
> -	npriv->nfs_port = ret;
> +	debug("nfs port: %d\n", npriv->nfs_port);
>  
>  	ret = nfs_mount_req(npriv);
>  	if (ret) {
> -- 
> 1.8.5.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-07  6:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-06 16:40 [PATCH 0/9] nfs3 support Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 1/9] net: net_read_uint32: assert that only 32 bit are read Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 2/9] nfs: skip over stale rpc packets Uwe Kleine-König
2014-02-07  8:20   ` Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 3/9] nfs: shorten and simplify rpc_add_credentials a bit Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 4/9] nfs: simplify rpc_lookup_req Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 5/9] nfs: drop an unneeded variable from nfs_do_open() Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 6/9] net: new function net_read_uint64 Uwe Kleine-König
2014-02-07  8:17   ` Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 7/9] mount: support filesystem options passed via -o Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 8/9] nfs: switch to nfs3 Uwe Kleine-König
2014-02-07  6:48   ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07  8:52     ` Uwe Kleine-König
2014-02-07  9:50       ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 10:23         ` Uwe Kleine-König
2014-02-06 16:40 ` [PATCH 9/9] nfs: parse nfsport and mount port from file system options Uwe Kleine-König
2014-02-07  6:50   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2014-02-07  8:22     ` Uwe Kleine-König
2014-02-07  8:45       ` Jean-Christophe PLAGNIOL-VILLARD
2014-02-07 10:06         ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140207065032.GG9671@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox