From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WBfOX-0005QK-KA for barebox@lists.infradead.org; Fri, 07 Feb 2014 06:58:38 +0000 Date: Fri, 7 Feb 2014 07:58:12 +0100 From: Sascha Hauer Message-ID: <20140207065811.GD16215@pengutronix.de> References: <1391640009-3399-1-git-send-email-sebastian.hesselbarth@gmail.com> <1391640009-3399-4-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1391640009-3399-4-git-send-email-sebastian.hesselbarth@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/6] bus: mvebu: add mbus driver To: Sebastian Hesselbarth Cc: Thomas Petazzoni , barebox@lists.infradead.org, Michael Grzeschik Hi Sebastian, On Wed, Feb 05, 2014 at 11:40:06PM +0100, Sebastian Hesselbarth wrote: > + * device accesses. This API is mvebu_mbus_add_window_by_id(), > + * mvebu_mbus_add_window_remap_by_id() and > + * mvebu_mbus_del_window(). > + * > + * - Provides a debugfs interface in /sys/kernel/debug/mvebu-mbus/ to > + * see the list of CPU -> SDRAM windows and their configuration > + * (file 'sdram') and the list of CPU -> devices windows and their > + * configuration (file 'devices'). > + */ I'm inclined to say that you should use dev_* functions for debugging, but I see the code is very close to the kernel and you don't have a struct device_d pointer everywhere. Up to you to use dev_*, but if not please add a #define pr_fmt here. > + > +#include > +#include > +#include > +#include > +#include > +#include > + [...] > + > +static const struct mvebu_mbus_soc_data orion5x_2win_mbus_data = { > + .num_wins = 8, > + .num_remappable_wins = 2, > + .win_cfg_offset = orion5x_mbus_win_offset, > + .setup_cpu_target = mvebu_mbus_default_setup_cpu_target, > +}; > + > +static const struct mvebu_mbus_soc_data mv78xx0_mbus_data = { > + .num_wins = 14, > + .num_remappable_wins = 8, > + .win_cfg_offset = mv78xx0_mbus_win_offset, > + .setup_cpu_target = mvebu_mbus_default_setup_cpu_target, > +}; Don't you end up with unused variable warnings here if not all SoCs are enabled? Maybe add some __maybe_unused here. > + > +static struct of_device_id mvebu_mbus_dt_ids[] = { > +#if defined(CONFIG_ARCH_ARMADA_370) || defined(CONFIG_ARCH_ARMADA_XP) > + { .compatible = "marvell,armada370-mbus", > + .data = (u32)&armada_370_xp_mbus_data, }, > + { .compatible = "marvell,armadaxp-mbus", > + .data = (u32)&armada_370_xp_mbus_data, }, > +#endif > +#if defined(CONFIG_ARCH_DOVE) > + { .compatible = "marvell,dove-mbus", > + .data = (u32)&dove_mbus_data, }, > +#endif Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox