From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 07/14] comamnds: uimage: actually print error message
Date: Fri, 7 Feb 2014 10:22:38 +0100 [thread overview]
Message-ID: <20140207092238.GF17045@pengutronix.de> (raw)
In-Reply-To: <1391762936-2747-8-git-send-email-dev@lynxeye.de>
Hi Lucas,
On Fri, Feb 07, 2014 at 09:48:49AM +0100, Lucas Stach wrote:
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> commands/uimage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/uimage.c b/commands/uimage.c
> index 345e496..4b0ed4d 100644
> --- a/commands/uimage.c
> +++ b/commands/uimage.c
> @@ -63,8 +63,8 @@ static int do_uimage(int argc, char *argv[])
> printf("verifying data crc... ");
> ret = uimage_verify(handle);
> if (ret) {
> - goto err;
> printf("Bad Data CRC\n");
> + goto err;
I'd drop the printf instead because in the bad crc case uimage_verify()
already printfs an error. But instead let it give tongue in the other
error cases (like lseek() or read() failing)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-02-07 9:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 8:48 [PATCH 00/14] Smatch warning fixups Lucas Stach
2014-02-07 8:48 ` [PATCH 01/14] remove redundant NULL check on free Lucas Stach
2014-02-07 8:48 ` [PATCH 02/14] commands: edit: properly propagate error code Lucas Stach
2014-02-07 8:48 ` [PATCH 03/14] common: env: " Lucas Stach
2014-02-07 8:48 ` [PATCH 04/14] clk: imx: unsigned mfn is never less than zero Lucas Stach
2014-02-07 8:48 ` [PATCH 05/14] lib: math: fix return path (numstack may be NULL) Lucas Stach
2014-02-07 8:48 ` [PATCH 06/14] lib: libbb: f should never be NULL Lucas Stach
2014-02-07 8:48 ` [PATCH 07/14] comamnds: uimage: actually print error message Lucas Stach
2014-02-07 9:22 ` Uwe Kleine-König [this message]
2014-02-07 8:48 ` [PATCH 08/14] usb: ulpi: fix logic-op Lucas Stach
2014-02-07 8:48 ` [PATCH 09/14] usb: dfu: fix error path to avoid NULL ptr deref Lucas Stach
2014-02-07 8:48 ` [PATCH 10/14] net: usb: smsc95xx: fix wrong phy reset condition Lucas Stach
2014-02-07 8:48 ` [PATCH 11/14] net: usb: asix: properly propagate error code Lucas Stach
2014-02-07 8:48 ` [PATCH 12/14] mtd: core: avoid possible NULL ptr deref Lucas Stach
2014-02-07 8:48 ` [PATCH 13/14] clk: " Lucas Stach
2014-02-07 8:48 ` [PATCH 14/14] don't cast negative error codes to unsigned size_t Lucas Stach
2014-02-07 9:17 ` Juergen Beisert
2014-02-10 7:51 ` [PATCH 00/14] Smatch warning fixups Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207092238.GF17045@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox