From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 6.mo2.mail-out.ovh.net ([87.98.165.38] helo=mo2.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WC1kL-00007V-Bx for barebox@lists.infradead.org; Sat, 08 Feb 2014 06:50:38 +0000 Received: from mail181.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo2.mail-out.ovh.net (Postfix) with SMTP id 276FAFFBAB4 for ; Sat, 8 Feb 2014 07:50:12 +0100 (CET) Date: Sat, 8 Feb 2014 07:51:28 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20140208065128.GM9671@ns203013.ovh.net> References: <1391808493-27328-1-git-send-email-u.kleine-koenig@pengutronix.de> <1391808493-27328-4-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1391808493-27328-4-git-send-email-u.kleine-koenig@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 04/11] nfs: shorten and simplify rpc_add_credentials a bit To: Uwe Kleine-K??nig Cc: barebox@lists.infradead.org On 22:28 Fri 07 Feb , Uwe Kleine-K??nig wrote: > Signed-off-by: Uwe Kleine-K=F6nig keep the hostname I use it on nfs for export filter Best Regards, J. > --- > fs/nfs.c | 26 +++++--------------------- > 1 file changed, 5 insertions(+), 21 deletions(-) > = > diff --git a/fs/nfs.c b/fs/nfs.c > index 76d8c0595db4..54dda261c0b1 100644 > --- a/fs/nfs.c > +++ b/fs/nfs.c > @@ -224,34 +224,18 @@ out_overflow: > */ > static uint32_t *rpc_add_credentials(uint32_t *p) > { > - int hl; > - int hostnamelen =3D 0; > - > /* > - * Here's the executive summary on authentication requirements of the > - * various NFS server implementations: Linux accepts both AUTH_NONE > - * and AUTH_UNIX authentication (also accepts an empty hostname field > - * in the AUTH_UNIX scheme). *BSD refuses AUTH_NONE, but accepts > - * AUTH_UNIX (also accepts an empty hostname field in the AUTH_UNIX > - * scheme). To be safe, use AUTH_UNIX and pass the hostname if we have > - * it (if the BOOTP/DHCP reply didn't give one, just use an empty > - * hostname). > + * *BSD refuses AUTH_NONE, so use AUTH_UNIX. An empty hostname is OK for > + * both Linux and *BSD. > */ > = > - hl =3D (hostnamelen + 3) & ~3; > - > /* Provide an AUTH_UNIX credential. */ > *p++ =3D htonl(1); /* AUTH_UNIX */ > - *p++ =3D htonl(hl + 20); /* auth length */ > + *p++ =3D htonl(20); /* auth length: 20 + strlen(hostname) */ > *p++ =3D htonl(0); /* stamp */ > - *p++ =3D htonl(hostnamelen); /* hostname string */ > - > - if (hostnamelen & 3) > - *(p + hostnamelen / 4) =3D 0; /* add zero padding */ > - > - /* memcpy(p, hostname, hostnamelen); */ /* empty hostname */ > + *p++ =3D htonl(0); /* hostname string length */ > + /* memcpy(p, "", 0); p +=3D 0; <- empty host name */ > = > - p +=3D hl / 4; > *p++ =3D 0; /* uid */ > *p++ =3D 0; /* gid */ > *p++ =3D 0; /* auxiliary gid list */ > -- = > 1.8.5.2 > = _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox