mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: i.MX53: Add sata to devicetree
Date: Mon, 10 Feb 2014 10:03:47 +0100	[thread overview]
Message-ID: <20140210090347.GK17250@pengutronix.de> (raw)
In-Reply-To: <20140210095418.1b36b791@e6520eb>

On Mon, Feb 10, 2014 at 09:54:18AM +0100, Eric Bénard wrote:
> Le Mon, 10 Feb 2014 09:52:35 +0100,
> Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> 
> > On Mon, Feb 10, 2014 at 09:48:19AM +0100, Eric Bénard wrote:
> > > Le Mon, 10 Feb 2014 12:40:44 +0400,
> > > Alexander Shiyan <shc_work@mail.ru> a écrit :
> > > 
> > > > Понедельник, 10 февраля 2014, 9:33 +01:00 от Sascha Hauer <s.hauer@pengutronix.de>:
> > > > > On Sat, Feb 08, 2014 at 06:26:41PM +0400, Alexander Shiyan wrote:
> > > > > > Суббота,  8 февраля 2014, 15:16 +01:00 от Eric Bénard <eric@eukrea.com>:
> > > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > > > ---
> > > > > > > arch/arm/dts/imx53.dtsi | 9 +++++++++
> > > > > > > 1 file changed, 9 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/arch/arm/dts/imx53.dtsi b/arch/arm/dts/imx53.dtsi
> > > > > > > index 678547c..91659b8 100644
> > > > > > > --- a/arch/arm/dts/imx53.dtsi
> > > > > > > +++ b/arch/arm/dts/imx53.dtsi
> > > > > > > @@ -75,6 +75,15 @@
> > > > > > > interrupt-parent = <&tzic>;
> > > > > > > ranges;
> > > > > > > 
> > > > > > > +		sata: sata@10000000 {
> > > > > > > +			compatible = "fsl,imx53-ahci";
> > > > > > > +			reg = <0x10000000 0x1000>;
> > > > > > > +			interrupts = <28>;
> > > > > > > +			clocks = <&clks 173>, <&clks 5>, <&clks 188>;
> > > > > > > +			clock-names = "sata", "ahb", "per";
> > > > > > > +			status = "disabled";
> > > > > > > +		};
> > > > > > 
> > > > > > Sascha, we stop changing DTS of the kernel or not?
> > > > > > What is the ultimate solution?
> > > > > 
> > > > > What do you suggest for the case above? A imx53-bb.dtsi included from
> > > > > imx53.dtsi? I think disallowing ahci support for barebox if it's not
> > > > > upstream in Linux is not a good option.
> > > > 
> > > > I suggest just sync imx53.dtsi from the linux-next, as a result we will have
> > > > non-modified version of kernel templates.
> > > > Change as above, makes imx53.dtsi different for kernel and barebox.
> > > > This is part of sata node from the kernel:
> > > > 		sata: sata@10000000 {
> > > > 			compatible = "fsl,imx53-ahci";
> > > > 			reg = <0x10000000 0x1000>;
> > > > 			interrupts = <28>;
> > > > 			clocks = <&clks IMX5_CLK_SATA_GATE>,
> > > > 				 <&clks IMX5_CLK_SATA_REF>,
> > > > 				 <&clks IMX5_CLK_AHB>;
> > > > 			clock-names = "sata_gate", "sata_ref", "ahb";
> > > > 			status = "disabled";
> > > > 		};
> > > > 
> > > that's possible, I don't know why the clock are changed in barebox vs
> > > linux and don't know if that's needed (I got inspiration from other
> > > nodes)
> > 
> > They are identical, it's only that Alexander introduced defines for the
> > clocks in Linux whereas in barebox we have the older versions with
> > plain numbers.
> > 
> clock-names are also changed as well as the order (taken from other
> nodes).

Oh, you are right. The order doesn't matter, but the names should be
identical. We should use the same names in barebox as in the kernel, be
it with defines or with numbers.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-10  9:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 14:16 [PATCH 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Eric Bénard
2014-02-08 14:16 ` [PATCH 2/7] ARM: i.MX53: Add sata to devicetree Eric Bénard
2014-02-08 14:26   ` Alexander Shiyan
2014-02-10  8:33     ` Sascha Hauer
2014-02-10  8:39       ` Eric Bénard
2014-02-10  8:40       ` Alexander Shiyan
2014-02-10  8:48         ` Eric Bénard
2014-02-10  8:52           ` Sascha Hauer
2014-02-10  8:54             ` Eric Bénard
2014-02-10  9:03               ` Sascha Hauer [this message]
2014-02-10  9:11                 ` Sascha Hauer
2014-03-07 10:39                   ` [PATCH v2 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Eric Bénard
2014-03-07 10:39                     ` [PATCH v2 2/7] ARM: i.MX53: Add sata to devicetree Eric Bénard
2014-03-10  7:08                       ` Sascha Hauer
2014-03-07 10:39                     ` [PATCH v2 3/7] ARM: mx53-qsrb: fix USB Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 4/7] ARM: mx53-qsrb: enable USB host Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 5/7] ARM: mx53-qsrb: enable USB OTG in host mode Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 6/7] ARM: mx53-qsrb: enable sata Eric Bénard
2014-03-07 10:40                     ` [PATCH v2 7/7] ARM: mx53-qsb: update defconfig Eric Bénard
2014-03-10  7:09                     ` [PATCH v2 1/7] sata-imx: i.MX53, use the internal 120MHz clock by default Sascha Hauer
2014-03-10  7:51                       ` Eric Bénard
2014-03-11  5:32                         ` Sascha Hauer
2014-02-10  9:07     ` [PATCH 2/7] ARM: i.MX53: Add sata to devicetree Sascha Hauer
2014-02-10  9:15       ` Sascha Hauer
2014-02-10  9:22         ` Alexander Shiyan
2014-02-08 14:16 ` [PATCH 3/7] ARM: mx53-qsrb: fix USB Eric Bénard
2014-02-08 14:16 ` [PATCH 4/7] ARM: mx53-qsrb: enable USB host Eric Bénard
2014-02-08 14:16 ` [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode Eric Bénard
2014-02-10  8:16   ` Sascha Hauer
2014-02-10  8:28     ` Eric Bénard
2014-02-10  8:31       ` Sascha Hauer
2014-02-10  8:37         ` Eric Bénard
2014-02-08 14:16 ` [PATCH 6/7] ARM: mx53-qsrb: enable sata Eric Bénard
2014-02-08 14:16 ` [PATCH 7/7] ARM: mx53-qsb: update defconfig Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210090347.GK17250@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eric@eukrea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox