Re: [PATCH 2/7] ARM: i.MX53: Add sata to devicetree

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Feb 10, 2014 at 09:54:18AM +0100, Eric Bénard wrote:
> Le Mon, 10 Feb 2014 09:52:35 +0100,
> Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> 
> > On Mon, Feb 10, 2014 at 09:48:19AM +0100, Eric Bénard wrote:
> > > Le Mon, 10 Feb 2014 12:40:44 +0400,
> > > Alexander Shiyan <shc_work@mail.ru> a écrit :
> > > 
> > > > Понедельник, 10 февраля 2014, 9:33 +01:00 от Sascha Hauer <s.hauer@pengutronix.de>:
> > > > > On Sat, Feb 08, 2014 at 06:26:41PM +0400, Alexander Shiyan wrote:
> > > > > > Суббота,  8 февраля 2014, 15:16 +01:00 от Eric Bénard <eric@eukrea.com>:
> > > > > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > > > > > ---
> > > > > > > arch/arm/dts/imx53.dtsi | 9 +++++++++
> > > > > > > 1 file changed, 9 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/arch/arm/dts/imx53.dtsi b/arch/arm/dts/imx53.dtsi
> > > > > > > index 678547c..91659b8 100644
> > > > > > > --- a/arch/arm/dts/imx53.dtsi
> > > > > > > +++ b/arch/arm/dts/imx53.dtsi
> > > > > > > @@ -75,6 +75,15 @@
> > > > > > > interrupt-parent = <&tzic>;
> > > > > > > ranges;
> > > > > > > 
> > > > > > > +		sata: sata@10000000 {
> > > > > > > +			compatible = "fsl,imx53-ahci";
> > > > > > > +			reg = <0x10000000 0x1000>;
> > > > > > > +			interrupts = <28>;
> > > > > > > +			clocks = <&clks 173>, <&clks 5>, <&clks 188>;
> > > > > > > +			clock-names = "sata", "ahb", "per";
> > > > > > > +			status = "disabled";
> > > > > > > +		};
> > > > > > 
> > > > > > Sascha, we stop changing DTS of the kernel or not?
> > > > > > What is the ultimate solution?
> > > > > 
> > > > > What do you suggest for the case above? A imx53-bb.dtsi included from
> > > > > imx53.dtsi? I think disallowing ahci support for barebox if it's not
> > > > > upstream in Linux is not a good option.
> > > > 
> > > > I suggest just sync imx53.dtsi from the linux-next, as a result we will have
> > > > non-modified version of kernel templates.
> > > > Change as above, makes imx53.dtsi different for kernel and barebox.
> > > > This is part of sata node from the kernel:
> > > > 		sata: sata@10000000 {
> > > > 			compatible = "fsl,imx53-ahci";
> > > > 			reg = <0x10000000 0x1000>;
> > > > 			interrupts = <28>;
> > > > 			clocks = <&clks IMX5_CLK_SATA_GATE>,
> > > > 				 <&clks IMX5_CLK_SATA_REF>,
> > > > 				 <&clks IMX5_CLK_AHB>;
> > > > 			clock-names = "sata_gate", "sata_ref", "ahb";
> > > > 			status = "disabled";
> > > > 		};
> > > > 
> > > that's possible, I don't know why the clock are changed in barebox vs
> > > linux and don't know if that's needed (I got inspiration from other
> > > nodes)
> > 
> > They are identical, it's only that Alexander introduced defines for the
> > clocks in Linux whereas in barebox we have the older versions with
> > plain numbers.
> > 
> clock-names are also changed as well as the order (taken from other
> nodes).

Oh, you are right. The order doesn't matter, but the names should be
identical. We should use the same names in barebox as in the kernel, be
it with defines or with numbers.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox