Re: [PATCH 2/7] ARM: i.MX53: Add sata to devicetree

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Feb 10, 2014 at 10:03:47AM +0100, Sascha Hauer wrote:
> > > > > I suggest just sync imx53.dtsi from the linux-next, as a result we will have
> > > > > non-modified version of kernel templates.
> > > > > Change as above, makes imx53.dtsi different for kernel and barebox.
> > > > > This is part of sata node from the kernel:
> > > > > 		sata: sata@10000000 {
> > > > > 			compatible = "fsl,imx53-ahci";
> > > > > 			reg = <0x10000000 0x1000>;
> > > > > 			interrupts = <28>;
> > > > > 			clocks = <&clks IMX5_CLK_SATA_GATE>,
> > > > > 				 <&clks IMX5_CLK_SATA_REF>,
> > > > > 				 <&clks IMX5_CLK_AHB>;
> > > > > 			clock-names = "sata_gate", "sata_ref", "ahb";
> > > > > 			status = "disabled";
> > > > > 		};
> > > > > 
> > > > that's possible, I don't know why the clock are changed in barebox vs
> > > > linux and don't know if that's needed (I got inspiration from other
> > > > nodes)
> > > 
> > > They are identical, it's only that Alexander introduced defines for the
> > > clocks in Linux whereas in barebox we have the older versions with
> > > plain numbers.
> > > 
> > clock-names are also changed as well as the order (taken from other
> > nodes).
> 
> Oh, you are right. The order doesn't matter, but the names should be
> identical. We should use the same names in barebox as in the kernel, be
> it with defines or with numbers.

So, Eric, to sort that out for now:

- Please update the SATA entry to be compatible with the kernel, but do
  not use the Linux-next dts. This means use plain numbers, but the
  correct clock names.
- Remove the dr_mode = "host" line

With these changes this series should be fine for merging.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox