From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp1-g21.free.fr ([2a01:e0c:1:1599::10]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WCmNC-0003Eq-CC for barebox@lists.infradead.org; Mon, 10 Feb 2014 08:37:51 +0000 Date: Mon, 10 Feb 2014 09:37:15 +0100 From: Eric =?ISO-8859-1?B?QuluYXJk?= Message-ID: <20140210093715.032a0db5@e6520eb> In-Reply-To: <20140210083148.GG17250@pengutronix.de> References: <1391868972-31978-1-git-send-email-eric@eukrea.com> <1391868972-31978-5-git-send-email-eric@eukrea.com> <20140210081617.GF17250@pengutronix.de> <20140210092854.5bf29d36@e6520eb> <20140210083148.GG17250@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 5/7] ARM: mx53-qsrb: enable USB OTG in host mode To: Sascha Hauer Cc: barebox@lists.infradead.org Le Mon, 10 Feb 2014 09:31:48 +0100, Sascha Hauer a =E9crit : > On Mon, Feb 10, 2014 at 09:28:54AM +0100, Eric B=E9nard wrote: > > Hi Sascha, > > = > > Le Mon, 10 Feb 2014 09:16:17 +0100, > > Sascha Hauer a =E9crit : > > > On Sat, Feb 08, 2014 at 03:16:10PM +0100, Eric B=E9nard wrote: > > > > &usbotg { > > > > - status =3D "okay"; > > > > + phy_type =3D "utmi"; > > > > + dr_mode =3D "host"; > > > > + status =3D "okay"; > > > > }; > > > = > > > Do we need a barebox specific option to specify dr_mode? I mean bareb= ox > > > cannot do otg, so we need to specify dr_mode to host or device, but w= ith > > > the above change Linux is limited to host mode aswell. > > > = > > in chipidea-imx.c there is : > > = > > mode =3D of_usb_get_dr_mode(ci->dev->device_node, NULL); > > = > > switch (mode) { > > case USB_DR_MODE_HOST: > > default: > > ci->mode =3D IMX_USB_MODE_HOST; > > break; > > case USB_DR_MODE_PERIPHERAL: > > ci->mode =3D IMX_USB_MODE_DEVICE; > > break; > > } > > = > > so we could omit the dr_mode=3Dhost as it will default to host. > = > Then let's do this. The default-to-host beahaviour in barebox may not > be desirable in all cases, but at least we do not propagate this > behaviour to the kernel. > = do you want a v2 or will you remove the line when applying ? Eric _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox