From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/8] common/kallsyms.c: Fix sparse warning
Date: Mon, 17 Feb 2014 08:25:08 +0100 [thread overview]
Message-ID: <20140217072508.GL17250@pengutronix.de> (raw)
In-Reply-To: <1392535477-21275-1-git-send-email-shc_work@mail.ru>
On Sun, Feb 16, 2014 at 11:24:30AM +0400, Alexander Shiyan wrote:
> CHECK common/kallsyms.c
> common/kallsyms.c:170:12: warning: symbol 'kallsyms_lookup' was not declared. Should it be static?
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Applied all, although with some of them I'm not sure whether the correct
fix would be to actually add the declaration to a header file instead of
making the symbol static.
Sascha
> ---
> common/kallsyms.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/kallsyms.c b/common/kallsyms.c
> index 94dfcdc..121b77c 100644
> --- a/common/kallsyms.c
> +++ b/common/kallsyms.c
> @@ -167,10 +167,10 @@ static unsigned long get_symbol_pos(unsigned long addr,
> * It resides in a module.
> * - We also guarantee that modname will be valid until rescheduled.
> */
> -const char *kallsyms_lookup(unsigned long addr,
> - unsigned long *symbolsize,
> - unsigned long *offset,
> - char **modname, char *namebuf)
> +static const char *kallsyms_lookup(unsigned long addr,
> + unsigned long *symbolsize,
> + unsigned long *offset,
> + char **modname, char *namebuf)
> {
> namebuf[KSYM_NAME_LEN - 1] = 0;
> namebuf[0] = 0;
> --
> 1.8.3.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-02-17 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 7:24 Alexander Shiyan
2014-02-16 7:24 ` [PATCH 2/8] drivers/clk/clk-fixed.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 3/8] drivers/clk/clk-fixed-factor.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 4/8] drivers/clk/clk-mux.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 5/8] drivers/clk/clk-gate.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 6/8] drivers/clk/clk-divider-table.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 7/8] drivers/i2c/i2c.c: Fix sparse warnings Alexander Shiyan
2014-02-16 7:24 ` [PATCH 8/8] drivers/of/base.c: " Alexander Shiyan
2014-02-17 7:25 ` Sascha Hauer [this message]
2014-02-17 7:30 ` [PATCH 1/8] common/kallsyms.c: Fix sparse warning Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217072508.GL17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox