From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/1] Add support for mx31moboard
Date: Thu, 27 Feb 2014 21:24:09 +0100 [thread overview]
Message-ID: <20140227202409.GR17250@pengutronix.de> (raw)
In-Reply-To: <1393509826-19549-1-git-send-email-philippe.retornaz@epfl.ch>
On Thu, Feb 27, 2014 at 03:03:44PM +0100, Philippe Rétornaz wrote:
> Hello
>
> This patch adds support for the mx31moboard board to bareboot.
> I've based this on the pcm037 board with some minor modifications
> in the clock and SDRAM initialisation.
>
> We were using redboot until now, barebox ease of use is quite a
> shock :)
Yeah, redboot is not exactly famous for good usability ;)
>
> BTW, I suspect there is a typo in the clock initialisation while
> writing the CCM_PDR0 register on the pcm037 board:
>
> writel(MX31_PDR0_CSI_PODF(0xff1) | \
> MX31_PDR0_PER_PODF(7) | \
> MX31_PDR0_HSP_PODF(3) | \
> MX31_PDR0_NFC_PODF(5) | \
> MX31_PDR0_IPG_PODF(1) | \
> MX31_PDR0_MAX_PODF(3) | \
> MX31_PDR0_MCU_PODF(0), \
> MX31_CCM_BASE_ADDR + MX31_CCM_PDR0);
>
> The CSI_PODF field is only 9 bits wide, thus, MX31_PDR0_CSI_PODF(0xff1)
> should better be MX31_PDR0_CSI_PODF(0x1ff).
Thanks for noting. This indeed looks buggy.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next parent reply other threads:[~2014-02-27 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1393509826-19549-1-git-send-email-philippe.retornaz@epfl.ch>
2014-02-27 20:24 ` Sascha Hauer [this message]
[not found] ` <1393509826-19549-2-git-send-email-philippe.retornaz@epfl.ch>
2014-02-27 20:36 ` [PATCH 1/1] ARM: i.MX31: Add support for mx31moboard board Sascha Hauer
2014-02-28 8:21 ` Philippe Rétornaz
2014-02-28 8:37 ` Sascha Hauer
2014-02-28 13:10 ` Philippe Rétornaz
2014-02-28 13:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227202409.GR17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=philippe.retornaz@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox