Re: [PATCH v2 00/10] new partitioning helper

[Sascha Hauer <s.hauer@pengutronix.de>]

On Fri, Feb 28, 2014 at 08:25:48AM +0100, Sascha Hauer wrote:
> On Thu, Feb 27, 2014 at 09:39:00PM +0100, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this is v2 of the series introducing devfs_create_partitions. With the
> > new syntax creating partitions is easier to parse for humans, it has
> > support to create partitions without holes inbetween without the need to
> > explicitly calculate the offsets and the code generated for the callers
> > is smaller.
> > 
> > I compared the size of arch/arm/boards/a9m2410/a9m2410.o with and
> > without the series with the kernel's bloat-o-meter, with the following
> > result:
> > 
> > add/remove: 1/0 grow/shrink: 0/1 up/down: 84/-104 (-20)
> > function                                     old     new   delta
> > a9m2410_nand0_partitions                       -      84     +84
> > a9m2410_devices_init                         296     192    -104
> > 
> > (Well, the size advantage is a *bit* relativized by the growth of fs/devfs-core.o:
> > 
> > add/remove: 3/0 grow/shrink: 0/1 up/down: 508/-124 (384)
> > function                                     old     new   delta
> > __devfs_add_partition.part                     -     376    +376
> > devfs_create_partitions                        -     128    +128
> > new                                            -       4      +4
> > devfs_add_partition                          296     172    -124
> > 
> > Don't know what "new" is above.)
> > 
> > Compared to (implicit) v1 of this series I dropped the compound
> > literals and used named static arrays instead as wished by Sebastian
> > Hesselbarth and Sascha Hauer.
> 
> Applied this series. I skipped the pca100 patch as this one has the
> partition layout in the devicetree now.

And I had a merge conflict in fs/devfs-core.c with:

commit 0c76b7e3779d1d38b8b70596b122bab076d9f26e
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Tue Jan 14 11:51:35 2014 +0100

    mtd: register mtd partitions as real mtd devices
    
    So far mtd partitions were mtd devices, but these were not registered.
    This patch changes this. mtd partitions are now registered like real
    mtd devices. This makes them part of the device hierarchy.
    
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

I'm confident I did it right, but maybe you better have a look at the
result in -next.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox