mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: i.MX31: Add support for mx31moboard board
Date: Fri, 28 Feb 2014 14:37:30 +0100	[thread overview]
Message-ID: <20140228133730.GC17250@pengutronix.de> (raw)
In-Reply-To: <53108AE3.80900@epfl.ch>

On Fri, Feb 28, 2014 at 02:10:59PM +0100, Philippe Rétornaz wrote:
> Le 28/02/2014 09:37, Sascha Hauer a écrit :
> >This may happen because the function gets too complex and gcc starts
> >using the stack in this case.
> >
> >Try rewriting the lowlevel stuff as:
> >
> >static void __noinline mx31_moboard_startup(void)
> >{
> >	/* Put setup here */
> >}
> >
> >void __bare_init __naked barebox_arm_reset_vector(void)
> >{
> >	 arm_cpu_lowlevel_init();
> >
> >	 arm_setup_stack(MX31_IRAM_BASE_ADDR + MX31_IRAM_SIZE - 12);
> >
> >	 mx31_moboard_startup();
> >}
> >
> >With this you can use the stack and should be on the safe side.
> 
> Ok, I tried and it works fine so I will do this.
> BTW, any reason for the -12, why not -8 ?

Probably historic reasons. I don't know exactly.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-02-28 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1393509826-19549-1-git-send-email-philippe.retornaz@epfl.ch>
2014-02-27 20:24 ` [PATCH 0/1] Add support for mx31moboard Sascha Hauer
     [not found] ` <1393509826-19549-2-git-send-email-philippe.retornaz@epfl.ch>
2014-02-27 20:36   ` [PATCH 1/1] ARM: i.MX31: Add support for mx31moboard board Sascha Hauer
2014-02-28  8:21     ` Philippe Rétornaz
2014-02-28  8:37       ` Sascha Hauer
2014-02-28 13:10         ` Philippe Rétornaz
2014-02-28 13:37           ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228133730.GC17250@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=philippe.retornaz@epfl.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox