From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/6] ARM: pfla02: Set new ethernet phy tx timings
Date: Fri, 14 Mar 2014 17:01:33 +0100 [thread overview]
Message-ID: <20140314160132.GA7755@omega> (raw)
In-Reply-To: <1394803820-29277-7-git-send-email-s.hauer@pengutronix.de>
On Fri, Mar 14, 2014 at 02:30:20PM +0100, Sascha Hauer wrote:
> From: Christian Hemp <c.hemp@phytec.de>
>
> TX_CLK line is approx. 54mm longer than other TX lines which adds
> a delay of 0.36ns. RGMII need a delay of min. 1.0ns. This mean we have to add
> a delay of 0.64ns. We choose 0.78 to have a little gap. This can be done by
> setting GTX pad skew value to 11100
> => Set register 2.8 (RGMII Clock Pad Skew) to 0x038F.
>
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>
> ---
> arch/arm/boards/phytec-phyflex-imx6/board.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boards/phytec-phyflex-imx6/board.c b/arch/arm/boards/phytec-phyflex-imx6/board.c
> index f510407..3db88da 100644
> --- a/arch/arm/boards/phytec-phyflex-imx6/board.c
> +++ b/arch/arm/boards/phytec-phyflex-imx6/board.c
> @@ -21,6 +21,9 @@
> #include <gpio.h>
> #include <init.h>
> #include <of.h>
> +#include <fec.h>
> +
> +#include <linux/micrel_phy.h>
>
> #include <mach/imx6.h>
>
> @@ -36,6 +39,21 @@ static int eth_phy_reset(void)
> return 0;
> }
>
> +static void mmd_write_reg(struct phy_device *dev, int device, int reg, int val)
> +{
> + phy_write(dev, 0x0d, device);
> + phy_write(dev, 0x0e, reg);
> + phy_write(dev, 0x0d, (1 << 14) | device);
> + phy_write(dev, 0x0e, val);
> +}
> +
> +static int ksz9031rn_phy_fixup(struct phy_device *dev)
> +{
> + mmd_write_reg(dev, 2, 8, 0x039F);
> +
commit msg says 0x038F and here is 0x039F. Which one is correct now?
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-03-14 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 13:30 Phytec phyFLEX i.MX6 patches Sascha Hauer
2014-03-14 13:30 ` [PATCH 1/6] ARM: i.MX6Q: Fix IOMUXC GPR1 bit 21 (ENET_CLK_SEL) Sascha Hauer
2014-03-14 13:30 ` [PATCH 2/6] ARM: pfla02: Drop unnecessary compilation of flash headers Sascha Hauer
2014-03-14 13:30 ` [PATCH 3/6] ARM: pfla02: add 4GB version Sascha Hauer
2014-03-14 13:30 ` [PATCH 4/6] ARM: pfla02: Set ODT to recommended setting Sascha Hauer
2014-03-17 11:00 ` Christian Hemp
2014-03-17 12:12 ` Sascha Hauer
2014-03-14 13:30 ` [PATCH 5/6] ARM: pfla02: Add support for DualLite and Solo core Sascha Hauer
2014-03-14 13:30 ` [PATCH 6/6] ARM: pfla02: Set new ethernet phy tx timings Sascha Hauer
2014-03-14 16:01 ` Alexander Aring [this message]
2014-03-17 6:24 ` Sascha Hauer
2014-03-17 6:40 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314160132.GA7755@omega \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox