* [PATCH] splash: Print error message when no renderer is found
@ 2014-03-14 10:11 Sascha Hauer
2014-03-14 17:11 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2014-03-14 10:11 UTC (permalink / raw)
To: barebox
the splash command silently fails when no renderer is found for
an image type. Print an error message in this case.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
lib/gui/image_renderer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
index 78e5777..9c92983 100644
--- a/lib/gui/image_renderer.c
+++ b/lib/gui/image_renderer.c
@@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
return ir;
}
+ printf("No renderer found for filetype %s\n", file_type_to_string(type));
+
return NULL;
}
--
1.9.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [SPAM] [PATCH] splash: Print error message when no renderer is found
2014-03-14 10:11 [PATCH] splash: Print error message when no renderer is found Sascha Hauer
@ 2014-03-14 17:11 ` Jean-Christophe PLAGNIOL-VILLARD
2014-03-17 7:21 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2014-03-14 17:11 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 11:11 Fri 14 Mar , Sascha Hauer wrote:
> the splash command silently fails when no renderer is found for
> an image type. Print an error message in this case.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> lib/gui/image_renderer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
> index 78e5777..9c92983 100644
> --- a/lib/gui/image_renderer.c
> +++ b/lib/gui/image_renderer.c
> @@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
> return ir;
> }
>
> + printf("No renderer found for filetype %s\n", file_type_to_string(type));
eprintf?
> +
> return NULL;
> }
>
> --
> 1.9.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [SPAM] [PATCH] splash: Print error message when no renderer is found
2014-03-14 17:11 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
@ 2014-03-17 7:21 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2014-03-17 7:21 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Fri, Mar 14, 2014 at 06:11:16PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:11 Fri 14 Mar , Sascha Hauer wrote:
> > the splash command silently fails when no renderer is found for
> > an image type. Print an error message in this case.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > lib/gui/image_renderer.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
> > index 78e5777..9c92983 100644
> > --- a/lib/gui/image_renderer.c
> > +++ b/lib/gui/image_renderer.c
> > @@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
> > return ir;
> > }
> >
> > + printf("No renderer found for filetype %s\n", file_type_to_string(type));
>
> eprintf?
ok
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-17 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-14 10:11 [PATCH] splash: Print error message when no renderer is found Sascha Hauer
2014-03-14 17:11 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
2014-03-17 7:21 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox