From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] ARM: initial support for RC Module UEMD SoCs
Date: Wed, 23 Apr 2014 10:35:13 +0200 [thread overview]
Message-ID: <20140423083513.GD5858@pengutronix.de> (raw)
In-Reply-To: <1397642260-32606-2-git-send-email-antonynpavlov@gmail.com>
On Wed, Apr 16, 2014 at 01:57:36PM +0400, Antony Pavlov wrote:
> This commit adds minimal support for the UEMD SoCs
> from RC Module (http://www.module.ru).
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> diff --git a/arch/arm/mach-uemd/reset.c b/arch/arm/mach-uemd/reset.c
> new file mode 100644
> index 0000000..df23e47
> --- /dev/null
> +++ b/arch/arm/mach-uemd/reset.c
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (C) 2014 Antony Pavlov <antonynpavlov@gmail.com>
> + *
> + * This file is part of barebox.
> + * See file CREDITS for list of people who contributed to this project.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +#include <common.h>
> +
> +void __noreturn reset_cpu(ulong addr)
> +{
> + unreachable();
unreachable is for marking positions in the code which are unreachable
but the compiler does not know it. reset_cpu() *is* reachable, so
unreachable is wrong here. How about just calling hang() here?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-23 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 9:57 [PATCH 0/5] ARM: initial support for RC Module UEMD SoCs and MB 77.07 board Antony Pavlov
2014-04-16 9:57 ` [PATCH 1/5] ARM: initial support for RC Module UEMD SoCs Antony Pavlov
2014-04-23 8:35 ` Sascha Hauer [this message]
2014-04-16 9:57 ` [PATCH 2/5] ARM: uemd: add DEBUG_LL support Antony Pavlov
2014-04-16 9:57 ` [PATCH 3/5] ARM: dts: add minimal К1879ХБ1Я devicetree file Antony Pavlov
2014-04-16 9:57 ` [PATCH 4/5] ARM: uemd: add mb7707 board support Antony Pavlov
2014-04-16 9:57 ` [PATCH 5/5] ARM: uemd: add module-mb7707_defconfig Antony Pavlov
2014-05-09 6:20 ` [PATCH 0/5] ARM: initial support for RC Module UEMD SoCs and MB 77.07 board Sascha Hauer
2014-05-09 7:49 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423083513.GD5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox