From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: loady: fix Y-Modem/G option name in help message
Date: Wed, 23 Apr 2014 11:20:08 +0200 [thread overview]
Message-ID: <20140423092008.GH5858@pengutronix.de> (raw)
In-Reply-To: <1397555958-28666-1-git-send-email-antonynpavlov@gmail.com>
On Tue, Apr 15, 2014 at 01:59:18PM +0400, Antony Pavlov wrote:
> Actually loady command uses '-g' option for Y-Modem/G mode
> selection; see loady() function:
>
> while ((opt = getopt(argc, argv, "b:t:g")) > 0) {
> switch (opt) {
> ...
> case 'g':
> is_ymodemg = 1;
> break;
>
> By mistake help message show '-y' option for Y-Modem/G mode
> selection.
>
> This patch fixes the problem.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> commands/loadxy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/loadxy.c b/commands/loadxy.c
> index 7a91286..93a423c 100644
> --- a/commands/loadxy.c
> +++ b/commands/loadxy.c
> @@ -241,7 +241,7 @@ BAREBOX_CMD_END
>
> static const __maybe_unused char cmd_loady_help[] =
> "[OPTIONS]\n"
> - " -y - use Y-Modem/G (only for lossless tty as USB)\n"
> + " -g - use Y-Modem/G (only for lossless tty as USB)\n"
> " -t name - console device name to use - defaults to current console\n"
> " -b baud - baudrate at which to download - defaults to console baudrate\n";
>
> --
> 1.9.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-04-23 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 9:59 Antony Pavlov
2014-04-23 9:20 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423092008.GH5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox